GH#34301: fix(site-context): match multisite children by aliases by vladimirdulov · Pull Request #34304 · marcusquinn/aidevops

vladimirdulov · 2026-10-11T00:23:43Z

Summary

Both child selections in lookup_record now match hostname or aliases using the existing jq index($hostname) pattern.
A child DNS record overrides the parent DNS record; absent child DNS still inherits parent DNS.
Documented child aliases and DNS inheritance in .agents/reference/site-operations.md and added the child alias example in .agents/configs/site-inventory.json.txt.

Resolves #34301

Runtime Testing

Risk: medium; testing level: runtime-verified.
Exact verified head: 5eb64fd.
Scratch inventory via AIDEVOPS_SITE_INVENTORY: hostname and two aliases return identical site_id, child identity 18, readiness ready, hosting and DNS (except matched_hostname).
lookup and discover resolve child aliases; unknown readiness remains gap and unknown lookup returns nonzero.
Checked child DNS/path overrides, parent DNS inheritance, missing aliases, parent key/canonical/alias and childless top-level sites.
env -u AIDEVOPS_SITE_INVENTORY bash .agents/scripts/tests/test-site-context-helper.sh: all checks pass.
shellcheck .agents/scripts/site-context-helper.sh: clean; jq template validation and git diff --check: pass; commit/push quality hooks: pass.

Self-review and acceptance

Inspected the complete three-file diff; all issue criteria are satisfied, including optional child DNS output. No unrelated changes.
Review bundle SHA-256: a52a97eea102b0992f1600d73bee58bad7fef2ba22df814d1356f58fe5326132; prompt-injection scan clean.
Existing matching semantics and hosting-account resolution are preserved; no provider calls or credential values added.

aidevops.sh v3.39.1 plugin for OpenCode v1.18.34 with gpt-6.1-sol spent 4m and 64,123 tokens on this as a headless worker.

coderabbitai · 2026-10-11T00:23:52Z

Important

Review skipped

Auto reviews are limited based on label configuration.

🏷️ Required labels (at least one) (1)

🚫 Excluded labels (none allowed) (1)

no-review

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository: marcusquinn/aidevops/.coderabbit.yaml
Review profile: CHILL
Plan: Advanced
Run ID: c77def72-8b60-4417-beb7-71d6a5c5b901

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

🔍 Trigger review

Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands.}

github-actions · 2026-10-11T00:24:12Z

Markdown Lint (changed-line scoped)

No new violations in changed lines (0 pre-existing in touched files — ignored).

Metric	Base (`ae5eb4f`)	Head (`5eb64fd`)
Total in touched files	—	0
New (in changed lines)	—	0

codacy-production · 2026-10-11T00:24:59Z

Up to standards ✅

🟢 Issues 0 issues

Results:
0 new issues

View in Codacy

_{NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer}
_{TIP This summary will be updated as you push new changes.}

github-actions · 2026-10-11T00:25:00Z

Qlty Smell Regression Gate

✅ No change — smell count unchanged.

Metric	Base (`ae5eb4f`)	Head (`5eb64fd`)	Delta
Total smells	65	65	+0

vladimirdulov · 2026-10-11T00:25:07Z

Completion Summary

What: Match multisite children by aliases and honor child DNS overrides, with parent DNS fallback.
Issue: site-context-helper: match multisite children by their aliases #34301
Files changed: .agents/scripts/site-context-helper.sh, .agents/reference/site-operations.md, .agents/configs/site-inventory.json.txt.
Testing: Exact head 5eb64fd; scratch inventory runtime checks for hostname/alias equivalence, lookup/discover, unknown gap, DNS/path overrides, inherited DNS, missing aliases and parent/childless records; existing test-site-context-helper.sh, ShellCheck, JSON validation, diff check and quality hooks passed.
Key decisions: Reuse existing jq alias matching in both selections; use the child DNS record as a full override when present; keep all changes within the canonical issue Files Scope.
Review: Direct self-review and acceptance comparison satisfy every issue criterion; bundle a52a97eea102b0992f1600d73bee58bad7fef2ba22df814d1356f58fe5326132.

aidevops.sh v3.39.1 plugin for OpenCode v1.18.34 with gpt-6.1-sol spent 4m and 69,598 tokens on this as a headless worker.

Merged via PR #34304 to main.
Merged by deterministic merge pass (pulse-wrapper.sh).

github-actions · 2026-10-11T00:25:19Z

Bash 3.2 Compatibility Regression Gate

✅ No regression — no new bash 3.2-incompatible construct(s).

Metric	Base (`ae5eb4f`)	Head (`5eb64fd`)
Total bash 3.2-incompatible construct(s)	0	0

github-actions · 2026-10-11T00:25:23Z

Shell Function Complexity Regression Gate

✅ No regression — no new function(s) >100 lines.

Metric	Base (`ae5eb4f`)	Head (`5eb64fd`)
Total function(s) >100 lines	0	0

github-actions · 2026-10-11T00:28:13Z

🔍 Code Quality Report

�[0;35m[MONITOR]�[0m Code Review Monitoring Report

SonarCloud: 0 bugs, 0 vulnerabilities, 1 code smells

Sun Oct 11 00:25:35 UTC 2026: Code review monitoring started
Sun Oct 11 00:25:36 UTC 2026: SonarCloud - Bugs: 0, Vulnerabilities: 0, Code Smells: 1
Sun Oct 11 00:28:04 UTC 2026: Codacy analysis completed - issues found (exit 2)

📈 Current Quality Metrics

BUGS: 0
CODE SMELLS: 1
VULNERABILITIES: 0

Generated on: Sun Oct 11 00:28:05 UTC 2026

Generated by AI DevOps Framework Code Review Monitoring

github-actions · 2026-10-11T00:29:20Z

Shell Nesting Depth Regression Gate

✅ No regression — no new file(s) with nesting depth >8.

Metric	Base (`ae5eb4f`)	Head (`5eb64fd`)
Total file(s) with nesting depth >8	0	0

github-actions · 2026-10-11T00:29:31Z

File Size Regression Gate

✅ No regression — no new non-README Markdown file(s) >1000 lines at root / >500 elsewhere.

Metric	Base (`ae5eb4f`)	Head (`5eb64fd`)
Total non-README Markdown file(s) >1000 lines at root / >500 elsewhere	0	0

alex-solovyev

Auto-approved by pulse runner @alex-solovyev — author @vladimirdulov confirmed collaborator, pre-merge gates passed.

aidevops.sh v3.39.1 automated scan.

wip: resolve multisite children by aliases

5eb64fd

vladimirdulov added the origin:worker Created by headless/pulse worker session label Oct 11, 2026

vladimirdulov mentioned this pull request Oct 11, 2026

[Supervisor:vladimirdulov] 3 open PRs, 0 issues assigned, 0 local workers — changed 2026-10-11 01:52 UTC #23855

Open

vladimirdulov marked this pull request as ready for review October 11, 2026 00:25

alex-solovyev approved these changes Oct 11, 2026

View reviewed changes

alex-solovyev merged commit 42d0f18 into main Oct 11, 2026
80 of 81 checks passed

alex-solovyev deleted the feature/auto-20261011-021920-gh34301 branch October 11, 2026 00:38

github-actions Bot added the status:done Task is complete label Oct 11, 2026

This was referenced Oct 11, 2026

site-context-helper: match multisite children by their aliases #34301

Closed

site inventory: record each site's purpose, ownership and DNS account #34303

Closed

GH#34303: feat(site-inventory): record purpose ownership and DNS accounts #34305

Merged

Navigation Menu

Repository navigation

GH#34301: fix(site-context): match multisite children by aliases - #34304

GH#34301: fix(site-context): match multisite children by aliases#34304
alex-solovyev merged 1 commit into
mainfrom
feature/auto-20261011-021920-gh34301

vladimirdulov commented Oct 11, 2026 •

edited

Loading

Uh oh!

coderabbitai Bot commented Oct 11, 2026 •

edited

Loading

Review skipped

Uh oh!

github-actions Bot commented Oct 11, 2026

Uh oh!

codacy-production Bot commented Oct 11, 2026

Uh oh!

github-actions Bot commented Oct 11, 2026

Uh oh!

vladimirdulov commented Oct 11, 2026 •

edited by alex-solovyev

Loading

Uh oh!

github-actions Bot commented Oct 11, 2026

Uh oh!

github-actions Bot commented Oct 11, 2026

Uh oh!

github-actions Bot commented Oct 11, 2026

Uh oh!

github-actions Bot commented Oct 11, 2026

Uh oh!

github-actions Bot commented Oct 11, 2026

Uh oh!

alex-solovyev left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

vladimirdulov commented Oct 11, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Runtime Testing

Self-review and acceptance

Uh oh!

coderabbitai Bot commented Oct 11, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Review skipped

Uh oh!

github-actions Bot commented Oct 11, 2026

Markdown Lint (changed-line scoped)

Uh oh!

codacy-production Bot commented Oct 11, 2026

Up to standards ✅

Uh oh!

github-actions Bot commented Oct 11, 2026

Qlty Smell Regression Gate

Uh oh!

vladimirdulov commented Oct 11, 2026 • edited by alex-solovyev Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Completion Summary

Uh oh!

github-actions Bot commented Oct 11, 2026

Bash 3.2 Compatibility Regression Gate

Uh oh!

github-actions Bot commented Oct 11, 2026

Shell Function Complexity Regression Gate

Uh oh!

github-actions Bot commented Oct 11, 2026

🔍 Code Quality Report

📈 Current Quality Metrics

Uh oh!

github-actions Bot commented Oct 11, 2026

Shell Nesting Depth Regression Gate

Uh oh!

github-actions Bot commented Oct 11, 2026

File Size Regression Gate

Uh oh!

alex-solovyev left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

vladimirdulov commented Oct 11, 2026 •

edited

Loading

coderabbitai Bot commented Oct 11, 2026 •

edited

Loading

vladimirdulov commented Oct 11, 2026 •

edited by alex-solovyev

Loading