Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some stl related cppcheck fixes #39072

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

jhaigh0
Copy link
Contributor

@jhaigh0 jhaigh0 commented Mar 17, 2025

Description of work

  • A couple std::string.starts_with warnings
  • A warning about searching a set before inserting
  • Some useStlAlg warnings

There is no associated issue.

To test:

  • Code check

Reviewer

Please comment on the points listed below (full description).
Your comments will be used as part of the gatekeeper process, so please comment clearly on what you have checked during your review. If changes are made to the PR during the review process then your final comment will be the most important for gatekeepers. In this comment you should make it clear why any earlier review is still valid, or confirm that all requested changes have been addressed.

Code Review

  • Is the code of an acceptable quality?
  • Does the code conform to the coding standards?
  • Are the unit tests small and test the class in isolation?
  • If there is GUI work does it follow the GUI standards?
  • If there are changes in the release notes then do they describe the changes appropriately?
  • Do the release notes conform to the release notes guide?

Functional Tests

  • Do changes function as described? Add comments below that describe the tests performed?
  • Do the changes handle unexpected situations, e.g. bad input?
  • Has the relevant (user and developer) documentation been added/updated?

Does everything look good? Mark the review as Approve. A member of @mantidproject/gatekeepers will take care of it.

Gatekeeper

If you need to request changes to a PR then please add a comment and set the review status to "Request changes". This will stop the PR from showing up in the list for other gatekeepers.

@jhaigh0 jhaigh0 added Maintenance Unassigned issues to be addressed in the next maintenance period. ISIS Team: Core Issue and pull requests managed by the Core subteam at ISIS labels Mar 17, 2025
@jhaigh0 jhaigh0 added this to the Release 6.13 milestone Mar 17, 2025
@jhaigh0 jhaigh0 force-pushed the some_stl_cppchecks branch from 8b034a2 to 82dec3f Compare March 17, 2025 11:16
@jhaigh0 jhaigh0 force-pushed the some_stl_cppchecks branch from 82dec3f to 99b8f4f Compare March 18, 2025 10:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ISIS Team: Core Issue and pull requests managed by the Core subteam at ISIS Maintenance Unassigned issues to be addressed in the next maintenance period.
Projects
Status: Awaiting Approval
Development

Successfully merging this pull request may close these issues.

1 participant