additional ccpcheck fixes from line numbers moving

Author: jhaigh0

buildconfig/CMake/CppCheck_Suppressions.txt.in

@@ -409,7 +409,6 @@ constParameterReference:${CMAKE_SOURCE_DIR}/Framework/Geometry/src/Crystal/Index
 unreadVariable:${CMAKE_SOURCE_DIR}/Framework/Geometry/src/Crystal/NiggliCell.cpp:233
 constParameterReference:${CMAKE_SOURCE_DIR}/Framework/Geometry/src/Crystal/OrientedLattice.cpp:381
 constVariableReference:${CMAKE_SOURCE_DIR}/Framework/Geometry/src/Crystal/ScalarUtils.cpp:389
-constVariableReference:${CMAKE_SOURCE_DIR}/Framework/Geometry/src/Crystal/SpaceGroupFactory.cpp:29
 constVariableReference:${CMAKE_SOURCE_DIR}/Framework/Geometry/src/Crystal/StructureFactorCalculatorSummation.cpp:55
 constParameterPointer:${CMAKE_SOURCE_DIR}/Framework/Geometry/src/IObjComponent.cpp:20
 constParameterPointer:${CMAKE_SOURCE_DIR}/Framework/Geometry/src/IObjComponent.cpp:31
@@ -685,11 +684,7 @@ constVariableReference:${CMAKE_SOURCE_DIR}/qt/widgets/common/src/ImageInfoModelM
 passedByValue:${CMAKE_SOURCE_DIR}/qt/widgets/common/src/ImageInfoPresenter.cpp:33
 constVariableReference:${CMAKE_SOURCE_DIR}/qt/widgets/common/src/InstrumentSelector.cpp:38
 constVariableReference:${CMAKE_SOURCE_DIR}/qt/widgets/common/src/ListPropertyWidget.cpp:46
-iterateByValue:${CMAKE_SOURCE_DIR}/qt/widgets/common/src/MantidTreeModel.cpp:35
 iterateByValue:${CMAKE_SOURCE_DIR}/qt/widgets/common/src/MantidTreeWidget.cpp:171
-iterateByValue:${CMAKE_SOURCE_DIR}/qt/widgets/common/src/MantidTreeWidget.cpp:191
-uninitvar:${CMAKE_SOURCE_DIR}/qt/widgets/common/src/MantidTreeWidget.cpp:248
-uninitStructMember:${CMAKE_SOURCE_DIR}/qt/widgets/common/src/MantidTreeWidget.cpp:248
 iterateByValue:${CMAKE_SOURCE_DIR}/qt/widgets/common/src/MantidWSIndexDialog.cpp:161
 constVariableReference:${CMAKE_SOURCE_DIR}/qt/widgets/common/src/MantidWSIndexDialog.cpp:629
 constVariableReference:${CMAKE_SOURCE_DIR}/qt/widgets/common/src/MessageDisplay.cpp:151

qt/widgets/common/src/MantidTreeWidget.cpp

@@ -187,7 +187,7 @@ QList<MatrixWorkspace_const_sptr> MantidTreeWidget::getSelectedMatrixWorkspaces(
   // Get the names of, and pointers to, the MatrixWorkspaces only.
   QList<MatrixWorkspace_const_sptr> selectedMatrixWsList;
   QList<QString> selectedMatrixWsNameList;
-  foreach (const auto selectedWsName, selectedWsNameList) {
+  foreach (const auto &selectedWsName, selectedWsNameList) {
     const auto matrixWs =
         std::dynamic_pointer_cast<const MatrixWorkspace>(m_ads.retrieve(selectedWsName.toStdString()));
     if (matrixWs) {
@@ -237,13 +237,15 @@ MantidWSIndexWidget::UserInput MantidTreeWidget::chooseSpectrumFromSelected(bool
       spectrumToPlot.insert(QString::fromStdString(selectedMatrixWs->getName()), SINGLE_SPECTRUM);
     }
     // and get simple 1D plot done
-    MantidWSIndexWidget::UserInput selections;
-    selections.plots = spectrumToPlot;
-    selections.simple = true;
-    selections.waterfall = false;
-    selections.tiled = false;
-    selections.surface = false;
-    selections.contour = false;
+    MantidWSIndexWidget::UserInput selections = {.plots = spectrumToPlot,
+                                                 .simple = true,
+                                                 .waterfall = false,
+                                                 .tiled = false,
+                                                 .errors = false,
+                                                 .surface = false,
+                                                 .contour = false,
+                                                 .isAdvanced = false,
+                                                 .advanced = NULL};
     return selections;
   }