update example #19
update example #19
Conversation
| /// - maximum associated with [task-arena-size](https://docs.embassy.dev/embassy-executor/git/cortex-m/index.html) | ||
| const SDC_MEMORY_SIZE: usize = 3312; // bytes | ||
| const SDC_MEMORY_SIZE: usize = 1448; // bytes |
There was a problem hiding this comment.
@alexmoon is it okay to set this memory size constant here? The runtime required_memory() function told me I had over allocated memory since the update, but I'm not sure if this is something the end application developer would need to have control over?
There was a problem hiding this comment.
This should be configurable by the end application, because it depends on how many connections and the l2cap mtu you want the controller to handle, so it can vary.
I'm OK if you want to merge this first though.
| /// - maximum associated with [task-arena-size](https://docs.embassy.dev/embassy-executor/git/cortex-m/index.html) | ||
| const SDC_MEMORY_SIZE: usize = 3312; // bytes | ||
| const SDC_MEMORY_SIZE: usize = 1448; // bytes |
There was a problem hiding this comment.
This should be configurable by the end application, because it depends on how many connections and the l2cap mtu you want the controller to handle, so it can vary.
I'm OK if you want to merge this first though.
|
Ah nice I wondered what it would depend on. I'll have a think about the easiest way to pull it out as an accessible const, the static SDC_MEM static made that awkward when I had a quick look before. |
My itch is to have jamessizeland/microbit-ble-gamepad#4 merged (different project; dependent) so that I can work in that project's Based on the conversations, I'm not quite sure if there's something remaining to be done here, or whether the merge could in fact take place? |
|
I'll finish updating the dependencies for the latest trouble updates on this today and get it merged. |
|
happy to merge @lulf ? |
Possibly worth waiting until embassy-rs/trouble#213 is merged.
Mostly just updating trouble example to match latest changes in the nrf-sdc example.