Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update trouble api #4

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

update trouble api #4

wants to merge 4 commits into from

Conversation

jamessizeland
Copy link
Owner

waiting on lulf/microbit-bsp#19 to merge

@jamessizeland jamessizeland marked this pull request as ready for review January 24, 2025 23:58
@jamessizeland
Copy link
Owner Author

I'm seeing weird behaviour on this update, the server keeps timing out on connection. @lure23 @lulf do you get a similar behaviour on your microbits? I can't see what is different in this to running the trouble example in microbit-bsp (which does work). So I'm wondering if it's indicating a bug somewhere...

39.388824 INFO  [host] disconnection event on handle 2, reason: Connection Timeout
└─ trouble_host::host::{impl#4}::run_with_handler::{async_fn#0} @ /home/.cargo/git/checkouts/trouble-148cf413cadab653/a1daee2/host/src/fmt.rs:143 
39.389007 INFO  Gatt server task finished

@lure23
Copy link
Contributor

lure23 commented Jan 25, 2025

I'm seeing weird behaviour on this update

Sorry, but I don't have a microbit to test with.

@lulf
Copy link
Contributor

lulf commented Jan 25, 2025

I'm seeing weird behaviour on this update, the server keeps timing out on connection. @lure23 @lulf do you get a similar behaviour on your microbits? I can't see what is different in this to running the trouble example in microbit-bsp (which does work). So I'm wondering if it's indicating a bug somewhere...

39.388824 INFO  [host] disconnection event on handle 2, reason: Connection Timeout
└─ trouble_host::host::{impl#4}::run_with_handler::{async_fn#0} @ /home/.cargo/git/checkouts/trouble-148cf413cadab653/a1daee2/host/src/fmt.rs:143 
39.389007 INFO  Gatt server task finished

@jamessizeland Could you test with embassy-rs/trouble#270 ? I'm wondering if it's a symptom that the outbound reply is dropped due to outbound buffers or something (I've not tried to debug this, so it's just guessing). If there is a lot of events and you want to make sure they all get replied to, you need to explicitly call event.accept()?.send().await so that it will wait until the reply is put into the outbound queue.

@jamessizeland
Copy link
Owner Author

I'll do so later yep ty!

@jamessizeland
Copy link
Owner Author

I switched to your branch and it connected and displayed characteristics in nrf-connect properly. But then I switched back to the rev that wasn't working yesterday and it connects just fine, so I'm unsure what the issue was!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants