Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependencies to latest #456

Merged
merged 2 commits into from
Sep 1, 2020
Merged

Update dependencies to latest #456

merged 2 commits into from
Sep 1, 2020

Conversation

bajtos
Copy link
Member

@bajtos bajtos commented Aug 28, 2020

  • eslint to 7.x
  • mocha to 8.x
  • uuid to 8.x
  • loopback-connector to 5.x

Checklist

  • DCO (Developer Certificate of Origin) signed in all commits
  • npm test passes on your machine
  • New tests added or existing tests modified to cover all changes
  • Code conforms with the style guide
  • Commit messages are following our guidelines

bajtos added 2 commits August 28, 2020 09:01
Replace `exit 1` to `return 1`, otherwise the entire shell (terminal
tab) is closed on errors.

Signed-off-by: Miroslav Bajtoš <[email protected]>
- `eslint` to 7.x
- `mocha` to 8.x
- `uuid` to 8.x
- `loopback-connector` to 5.x

Signed-off-by: Miroslav Bajtoš <[email protected]>
@bajtos bajtos requested a review from agnes512 August 28, 2020 11:54
@bajtos bajtos self-assigned this Aug 28, 2020
@bajtos bajtos merged commit 2e41054 into master Sep 1, 2020
@delete-merged-branch delete-merged-branch bot deleted the update-deps branch September 1, 2020 12:26
@billinghamj
Copy link

@bajtos Flagging this here too - following this change, with the latest of this lib and the juggler lib, you end up with two versions of the connector. loopbackio/loopback-connector#181 (comment)

@dhmlau
Copy link
Member

dhmlau commented Oct 7, 2020

@billinghamj, thanks for bringing it up. Could you please open a new issue? It's hard to keep track of the discussion in a merged PR. Thanks!

@billinghamj
Copy link

#463

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants