Skip to content

#456 causes multiple major versions of loopback-connector #463

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
billinghamj opened this issue Oct 8, 2020 · 3 comments · Fixed by loopbackio/loopback-datasource-juggler#1870
Assignees
Labels

Comments

@billinghamj
Copy link

Opening this issue as requested #456 (comment)

Following #456, the latest version of loopback-connector-postgresql refers to loopback-connector v5, but the latest version of loopback-datasource-juggler refers to loopback-connector v4, resulting in two different versions having to be installed at the same time.

It seems it's necessary to release a new version of loopback-datasource-juggler with updated dependencies to address this.

@dhmlau
Copy link
Member

dhmlau commented Oct 8, 2020

@bajtos, could you please take a look? Thanks.

@bajtos
Copy link
Member

bajtos commented Oct 12, 2020

@billinghamj in loopbackio/loopback-connector#181 (comment), you wrote:

it seems like a fairly big problem to have two incompatible versions running together?

As far as I know, it's fine to have multiple versions of the same module installed in the same project. In LoopBack, we go quite far to ensure our code is designed to handle multiple versions of the same module installed.

Is there any particular issue you are running into?

Having said that, I agree we should update loopback-datasource-juggler to use the latest version of loopback-connector too, I'll open a pull request soon.

(UPDATE) You can find the pull request here: loopbackio/loopback-datasource-juggler#1870

@billinghamj
Copy link
Author

No particular issue, just the concern that loopback is pretty fragile in our stack and I want to avoid the risk

Thanks for updating it! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants