feat: remove usage of build yaml for list-deps #4192
Conversation
cdoern
requested review from
ashwinb,
bbrowning,
ehhuang,
franciscojavierarceo,
hardikjshah,
leseb,
mattf,
raghotham,
reluctantfuturist,
slekkala1 and
yanxi0830
as code owners
meta-cla
bot
added
the
CLA Signed
|
hmmm, need to fix CI. seems the env variables are causing issues. |
|
Is there a corresponding change to documentation? |
|
@raghotham , I believe the current documentation only shows |
cdoern
force-pushed
the
rm-build
branch
3 times, most recently
from
3557032 to
ed55bcc
Compare
the build.yaml is only used in the following ways: 1. list-deps 2. distribution code-gen since `llama stack build` no longer exists, I found myself asking "why do we need two different files for list-deps and run"? Removing the BuildConfig and DistributionTemplate from llama stack list-deps is the first step in removing the build yaml entirely. Removing the BuildConfig and build.yaml cuts the files users need to maintain in half, and allows us to focus on the stability of _just_ the run.yaml The build.yaml made sense for when we were managing the build process for the user and actually _producing_ a run.yaml _from_ the build.yaml, but now that we are simply just getting the provider registry and listing the deps, switching to run.yaml simplifies the scope here greatly Signed-off-by: Charlie Doern <[email protected]>
all of the additional pip packages are already in `llama-stack`'s pyproject except for psycopg2-binary (which I added), so they are unnecessary. This also allows me to get rid of the additional_pip_packages field Signed-off-by: Charlie Doern <[email protected]>
why do we want to remove |
|
@ashwinb you're right, that was an oversight on my part. instead |
Signed-off-by: Charlie Doern <[email protected]>
leseb
left a comment
leseb
left a comment
There was a problem hiding this comment.
How about renaminging StackRunConfig to StackConfig and stop using run.yaml but config.yaml.
| "asyncpg", # for metadata store | ||
| "sqlalchemy[asyncio]>=2.0.41", # server - for conversations | ||
| "starlette>=0.49.1", | ||
| "psycopg2-binary", |
4 participants
What does this PR do?
the build.yaml is only used in the following ways:
since
llama stack buildno longer exists, I found myself asking "why do we need two different files for list-deps and run"?Removing the BuildConfig and altering the usage of the DistributionTemplate in llama stack list-deps is the first step in removing the build yaml entirely.
Removing the BuildConfig and build.yaml cuts the files users need to maintain in half, and allows us to focus on the stability of just the run.yaml
The build.yaml made sense for when we were managing the build process for the user and actually producing a run.yaml from the build.yaml, but now that we are simply just getting the provider registry and listing the deps, switching to run.yaml simplifies the scope here greatly.
Test Plan
existing list-deps usage should work in the tests.