fix(ci): prefix stainless branches with fork author #4187
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meta-cla
bot
added
the
CLA Signed
dgellow
force-pushed
the
sam/workflow-prefix-fork-branches
branch
from
460da26 to
02caff8
Compare
Contributor
✱ Stainless preview buildsThis PR will update the Edit this comment to update it. It will appear in the SDK's changelogs. ✅ llama-stack-client-go studio · code · diff
✅ llama-stack-client-node studio · code · diff
⏳ These are partial results; builds are still running. This comment is auto-generated by GitHub Actions and is automatically kept up to date as you push. |
dgellow
force-pushed
the
sam/workflow-prefix-fork-branches
branch
from
5d9a402 to
7c4b5cb
Compare
dgellow
requested review from
ashwinb,
bbrowning,
ehhuang,
franciscojavierarceo,
hardikjshah,
leseb,
mattf,
raghotham,
reluctantfuturist,
slekkala1 and
yanxi0830
as code owners
dgellow
force-pushed
the
sam/workflow-prefix-fork-branches
branch
from
7c4b5cb to
574dac4
Compare
ashwinb
approved these changes
Nov 19, 2025
Contributor
|
OK I am landing this right now to unblock the other PR, but we can slightly clean this up later to reduce duplication. |
ashwinb
pushed a commit
that referenced
this pull request
Nov 19, 2025
# What does this PR do? <!-- Provide a short summary of what this PR does and why. Link to relevant issues if applicable. --> Addresses feedback from #4187 (comment) <!-- If resolving an issue, uncomment and update the line below --> <!-- Closes #[issue-number] --> ## Test Plan <!-- Describe the tests you ran to verify your changes with result summaries. *Provide clear instructions so the plan can be easily re-executed.* -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
I believe that should avoid CI issues seen in #4173.
Error we see in Stainless logs:
The issue is that if a branch
fixexists,fix/<whatever>cannot be created (that's how git refs work unfortunately...). The fix in this PR is to ensure PRs from forks are using the author as a prefix.In addition we will do changes to the Stainless API to return better error messages here, it should have been a 4xx with a meaningful error, not a 500.
And we will likely need to delete the
fixbranch.Test Plan