Skip to content

Conversation

@dgellow
Copy link
Contributor

@dgellow dgellow commented Nov 19, 2025

What does this PR do?

Addresses feedback from #4187 (comment)

Test Plan

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Meta Open Source bot. label Nov 19, 2025
@ashwinb
Copy link
Contributor

ashwinb commented Nov 19, 2025

@dgellow: can we have a test plan here where you just modify the openapi.yml randomly (and manually) for an iteration so we can see if all is cool with the preview build and then update openapi.yml back? Or any other way to ascertain this works as expected? (It does look correct.)

@dgellow
Copy link
Contributor Author

dgellow commented Nov 19, 2025

Unfortunately that won't work (I found that with my previous PR). Because this PR has been opened from a fork the version of the workflow that runs is the one from the base repo 😬

Copy link
Contributor

@ashwinb ashwinb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

alright, yolo #whatcouldgowrong

@ashwinb ashwinb merged commit aa2a7da into llamastack:main Nov 19, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Meta Open Source bot.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants