-
Notifications
You must be signed in to change notification settings - Fork 121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
A foundation for text editing and selection in Masonry #241
Conversation
//TODO: add inking_rect | ||
} | ||
|
||
impl<T> TextLayout<T> { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a general comment that some things are prefixing with set_
and others with set_text_
and sometimes set_color
is used in here and in other places set_text_color
and it might be nice to make this more consistent. (Probably not immediately before RustNL...)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, all of this API design could do with a tiny bit of cleanup; there's quite a lot of redundancy in these methods
Doesn't do selections yet
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving in the interest of v0.1 for RustNL, with the understanding that the code introduced here is buggy and is missing functionality that will be addressed in future PRs.
This brings in a lot of the old work from Druid and Masonry (prior to linebender/masonry#56) on text, as well as some types from Glazier.
Needed work:
Follow up work: