Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup the text widgets to not be generic #260

Merged
merged 1 commit into from
May 5, 2024

Conversation

DJMcNab
Copy link
Member

@DJMcNab DJMcNab commented May 5, 2024

This is fallout from #241. As discussed on Zulip, using different underlying text types here is a very advanced feature, which will not be needed by any real consumers. It also creates some footguns

Probably conflicts with #257, so that should land first

Copy link
Contributor

@PoignardAzur PoignardAzur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@DJMcNab DJMcNab force-pushed the better-text-widgets branch from 98700c5 to d626337 Compare May 5, 2024 13:21
@DJMcNab DJMcNab enabled auto-merge May 5, 2024 13:22
@DJMcNab DJMcNab added this pull request to the merge queue May 5, 2024
Merged via the queue into linebender:main with commit 9542aaf May 5, 2024
7 checks passed
@DJMcNab DJMcNab deleted the better-text-widgets branch May 5, 2024 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants