Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Setup workflows for OpenAPI code generation #366

Merged
merged 8 commits into from
Apr 1, 2025
Merged

Setup workflows for OpenAPI code generation #366

merged 8 commits into from
Apr 1, 2025

Conversation

mokuzon
Copy link
Contributor

@mokuzon mokuzon commented Jan 21, 2025

resolve #304 #346 #346 and #361

The following code has been added and updated based on code in other languages.

  • Workflow for OpenAPI code generation
  • Renovate configuration file

@mokuzon mokuzon self-assigned this Jan 21, 2025
@mokuzon mokuzon force-pushed the features/openapi-ci branch 3 times, most recently from 4a52164 to 10e1520 Compare January 21, 2025 02:54
@mokuzon mokuzon requested a review from a team January 21, 2025 03:06
Yang-33
Yang-33 approved these changes Jan 21, 2025
View reviewed changes
Copy link
Contributor

@Yang-33 Yang-33 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you! Please create line-openapi-update label before merge.

Yang-33
Yang-33 reviewed Jan 21, 2025
View reviewed changes
.github/workflows/generate-code.yml Outdated
Comment on lines 22 to 25
- name: Set up Python
uses: actions/setup-python@v5
with:
python-version: '3.x'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

probably we can remove this. python is installed in default github action runner. (sorry I can't find url...)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://github.com/actions/runner-images/blob/c21e3961c52a5611ee44c3d33b1b11ac7a4636b7/images/ubuntu/Ubuntu2404-Readme.md?plain=1#L27

This was linked to issues Jan 21, 2025
CI: PR must fail when generated code is not committed #346
Closed
Set up renovate config for line-openapi #361
Closed
CI: Set title and description written in line-openapi PR #347
Closed
Yang-33
Yang-33 requested changes Mar 12, 2025
View reviewed changes
Copy link
Contributor

@Yang-33 Yang-33 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you modify a workflow for testing to resolve #304 ?

@Yang-33
Copy link
Contributor

Yang-33 commented Mar 12, 2025

To resolve this, I think running generate-code.py is required here

line-bot-sdk-ruby/.github/workflows/pull_request.yml

Lines 21 to 24 in 01d06cc

- run: gem install bundler
- run: bundle install
- run: bundle exec rubocop
- run: bundle exec rspec

Yang-33
Yang-33 reviewed Mar 26, 2025
View reviewed changes
renovate.json5 Outdated
{
"$schema": "https://docs.renovatebot.com/renovate-schema.json",
"extends": [
"config:recommended"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please add "helpers:pinGitHubActionDigestsToSemver" in extends!

ref: https://github.com/line/line-bot-sdk-ruby/pull/405/files

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

5ea1cb8

.github/workflows/generate-code.yml
tests:
name: Generate OpenAPI based code
runs-on: ubuntu-latest

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you add

    permissions:
      contents: write
      pull-requests: write

explicitly?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1545dc0

.github/workflows/generate-code.yml Outdated

steps:
# Setup
- uses: actions/checkout@v4
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you run pinact run -u to pin commit hash of github actions in your local?
(brew install pinact is required)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

b11c995

This was referenced Mar 27, 2025
Closed
Closed
Closed
@mokuzon mokuzon force-pushed the features/openapi-ci branch 3 times, most recently from 71533b4 to d574ea8 Compare April 1, 2025 01:50
@mokuzon mokuzon force-pushed the features/openapi-ci branch from 2364a77 to 285e549 Compare April 1, 2025 02:17
@mokuzon mokuzon requested a review from Yang-33 April 1, 2025 02:19
@mokuzon
Copy link
Contributor Author

mokuzon commented Apr 1, 2025

@Yang-33 I am very sorry for the pause! Please re-review.

Yang-33
Yang-33 approved these changes Apr 1, 2025
View reviewed changes
Copy link
Contributor

@Yang-33 Yang-33 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@Yang-33 Yang-33 merged commit 3fc5017 into line:master Apr 1, 2025
6 checks passed
@mokuzon mokuzon deleted the features/openapi-ci branch April 1, 2025 03:46
@Yang-33
Copy link
Contributor

Yang-33 commented Apr 1, 2025

https://github.com/line/line-bot-sdk-ruby/actions/runs/14186695823 CI passed after merging this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Yang-33 Yang-33 Yang-33 approved these changes

Assignees

@mokuzon mokuzon

Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@mokuzon @Yang-33