Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI: PR must fail when generated code is not committed #346

Closed
Yang-33 opened this issue Dec 20, 2024 · 0 comments · Fixed by #366
Closed

CI: PR must fail when generated code is not committed #346

Yang-33 opened this issue Dec 20, 2024 · 0 comments · Fixed by #366
Labels
keep
Milestone
generate code by ...

Comments

@Yang-33
Copy link
Contributor

Yang-33 commented Dec 20, 2024

When performing code generation, not committing the generated code can lead to unexpected code being merged into the master branch. The code generation results on CI should match the diff in the PR.

probably coping them works
@Yang-33 Yang-33 added the keep label Dec 20, 2024
@Yang-33 Yang-33 changed the title PR must fail when generated code is not committed CI: PR must fail when generated code is not committed Dec 20, 2024
mokuzon added a commit to mokuzon/line-bot-sdk-ruby that referenced this issue Jan 21, 2025
@mokuzon
Add generate-code workflow line#304 line#346 line#347
2aa3348
mokuzon added a commit to mokuzon/line-bot-sdk-ruby that referenced this issue Jan 21, 2025
@mokuzon
fixup! Add generate-code workflow line#304 line#346 line#347
75ef18f
mokuzon added a commit to mokuzon/line-bot-sdk-ruby that referenced this issue Jan 21, 2025
@mokuzon
Add generate-code workflow line#304 line#346 line#347
43e6af3
@mokuzon mokuzon mentioned this issue Jan 21, 2025
Merged
mokuzon added a commit to mokuzon/line-bot-sdk-ruby that referenced this issue Jan 21, 2025
@mokuzon
Add generate-code workflow line#304 line#346 line#347
f79e93a
mokuzon added a commit to mokuzon/line-bot-sdk-ruby that referenced this issue Jan 21, 2025
@mokuzon
Add generate-code workflow line#304 line#346 line#347
0bc5b14
mokuzon added a commit to mokuzon/line-bot-sdk-ruby that referenced this issue Jan 21, 2025
@mokuzon
Add generate-code workflow line#304 line#346 line#347
3aba3c6
@Yang-33 Yang-33 linked a pull request Jan 21, 2025 that will close this issue
Setup workflows for OpenAPI code generation #366
Merged
mokuzon added a commit to mokuzon/line-bot-sdk-ruby that referenced this issue Apr 1, 2025
@mokuzon
Add generate-code workflow line#304 line#346 line#347
e62fc99
mokuzon added a commit to mokuzon/line-bot-sdk-ruby that referenced this issue Apr 1, 2025
@mokuzon
fixup! Add generate-code workflow line#304 line#346 line#347
5b8e0e7
Yang-33 pushed a commit that referenced this issue Apr 1, 2025
@mokuzon
Setup workflows for OpenAPI code generation (#366)
3fc5017 
resolve #304 #346 #346 and #361

The following code has been added and updated based on code in other
languages.

- Workflow for OpenAPI code generation
- Renovate configuration file
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
keep
Projects
None yet
Milestone
generate code by openapi generator
Development

Successfully merging a pull request may close this issue.

Setup workflows for OpenAPI code generation mokuzon/line-bot-sdk-ruby
1 participant
@Yang-33