Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add JSON5 support #655

Open
wants to merge 23 commits into
base: main
Choose a base branch
from

Merge branch 'master' into json5-support

849bdb2
Select commit
Loading
Failed to load commit list.
Open

Add JSON5 support #655

Merge branch 'master' into json5-support
849bdb2
Select commit
Loading
Failed to load commit list.
Codecov / codecov/patch succeeded Oct 11, 2024 in 1s

94.39% of diff hit (target 70.04%)

View this Pull Request on Codecov

94.39% of diff hit (target 70.04%)

Annotations

Check warning on line 1068 in client/java-armeria/src/main/java/com/linecorp/centraldogma/client/armeria/ArmeriaCentralDogma.java

See this annotation in the file changed.

@codecov codecov / codecov/patch

client/java-armeria/src/main/java/com/linecorp/centraldogma/client/armeria/ArmeriaCentralDogma.java#L1067-L1068 

Added lines #L1067 - L1068 were not covered by tests

Check warning on line 126 in common/src/main/java/com/linecorp/centraldogma/common/Change.java

See this annotation in the file changed.

@codecov codecov / codecov/patch

common/src/main/java/com/linecorp/centraldogma/common/Change.java#L126 

Added line #L126 was not covered by tests

Check warning on line 60 in common/src/main/java/com/linecorp/centraldogma/internal/Json5.java

See this annotation in the file changed.

@codecov codecov / codecov/patch

common/src/main/java/com/linecorp/centraldogma/internal/Json5.java#L59-L60 

Added lines #L59 - L60 were not covered by tests
View more details on Codecov