Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add JSON5 support #655

Open
wants to merge 23 commits into
base: main
Choose a base branch
from

Merge branch 'master' into json5-support

849bdb2
Select commit
Loading
Failed to load commit list.
Open

Add JSON5 support #655

Merge branch 'master' into json5-support
849bdb2
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Oct 11, 2024 in 0s

70.34% (+0.29%) compared to 0ed7a9a

View this Pull Request on Codecov

70.34% (+0.29%) compared to 0ed7a9a

Details

Codecov Report

Attention: Patch coverage is 94.39252% with 6 lines in your changes missing coverage. Please review.

Project coverage is 70.34%. Comparing base (0ed7a9a) to head (849bdb2).
Report is 251 commits behind head on main.

Files with missing lines Patch % Lines
...ntraldogma/client/armeria/ArmeriaCentralDogma.java 80.00% 2 Missing ⚠️
...java/com/linecorp/centraldogma/internal/Json5.java 88.88% 2 Missing ⚠️
.../java/com/linecorp/centraldogma/common/Change.java 91.66% 1 Missing ⚠️
...n/java/com/linecorp/centraldogma/common/Entry.java 92.85% 0 Missing and 1 partial ⚠️
Additional details and impacted files 
@@             Coverage Diff              @@
##               main     #655      +/-   ##
============================================
+ Coverage     70.04%   70.34%   +0.29%     
- Complexity     3415     3458      +43     
============================================
  Files           349      350       +1     
  Lines         13482    13544      +62     
  Branches       1454     1466      +12     
============================================
+ Hits           9444     9528      +84     
+ Misses         3153     3135      -18     
+ Partials        885      881       -4

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

View more details on Codecov