feat: added a default --yes flag to set the tty
#3342
Conversation
There was a problem hiding this comment.
I wonder what should happen if the user specifies contradictory settings, like --tty --yes or --tty=false --yes=false.
You could say a later option should override an earlier one, but I don't know if that can easily be done with Cobra.
An alternative (and I suspect the correct one in this case) would be to throw an error instead of randomly picking one setting over the other.
👍 on this Also, please squash the commits |
changes have been made to throw an error when both |
| if err != nil { | ||
| return err | ||
| } | ||
| } |
There was a problem hiding this comment.
What if --yes=false is explicitly specified?
There was a problem hiding this comment.
Setting the value of --yes=false will not induce any effects and it will be neglected. we can just give a warning to user to prevent confusion.
cmd/limactl/main.go
Outdated
| @@ -68,6 +68,7 @@ func newApp() *cobra.Command { | |||
| rootCmd.PersistentFlags().Bool("debug", false, "debug mode") | |||
| // TODO: "survey" does not support using cygwin terminal on windows yet | |||
| rootCmd.PersistentFlags().Bool("tty", isatty.IsTerminal(os.Stdout.Fd()), "Enable TUI interactions such as opening an editor. Defaults to true when stdout is a terminal. Set to false for automation.") | |||
| rootCmd.PersistentFlags().BoolP("yes", "y", isatty.IsTerminal(os.Stdout.Fd()), "Alias of --tty=false") | |||
There was a problem hiding this comment.
The default value seems conflicting with tty
There was a problem hiding this comment.
The default value of the yes flag is changed to false which should behave as expected now.
Signed-off-by: Surya Prakash <[email protected]> - created a new boolean flag `--yes' Signed-off-by: Surya Prakash <[email protected]> fix: required changes Signed-off-by: Surya Prakash <[email protected]> - added intutive help message for the `--yes' flag - added a check with `cmd.Flags().Changed()` - changed the variable name from `ttyValue` to `yesValue` for better understanding feat: added a check usage of --yes && --tty Signed-off-by: Surya Prakash <[email protected]> fix: removed space from deprecated.md Fix: default value of the flag
fixes #3340