added --yes flag to edit #3350
Closed
added --yes flag to edit #3350
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Kairvee Vaswani <[email protected]>
|
Thanks, but a duplicate of |
AkihiroSuda
reviewed
Mar 14, 2025
| @@ -33,11 +34,25 @@ func newEditCommand() *cobra.Command { | |||
| ValidArgsFunction: editBashComplete, | |||
| GroupID: basicCommand, | |||
| } | |||
| editCommand.PersistentFlags().BoolP("yes", "y", isatty.IsTerminal(os.Stdout.Fd()), "Alias of --tty=false") | |||
There was a problem hiding this comment.
This was expected to be added as a global flag, as in --tty
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #3345
I have tried to fix it for edit , could you once review it so that I can proceed with the shell as well
also is there a specific reason to mention the closed issue here?