-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
lnrpc+rpcserver: add custom channel data for closed channels #9504
Conversation
Important Review skippedAuto reviews are limited to specific labels. 🏷️ Labels to auto review (1)
Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, please add an itest on the litd side, as long as we cannot test it here in LND.
@@ -1751,6 +1751,10 @@ message ChannelCloseSummary { | |||
|
|||
// The confirmed SCID for a zero-conf channel. | |||
uint64 zero_conf_confirmed_scid = 15 [jstype = JS_STRING]; | |||
|
|||
// The TLV encoded custom channel data records for this output, which might |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"might be set for custom channels", so its not always set for custom channels ?
err = fn.MapOptionZ( | ||
r.server.implCfg.AuxDataParser, | ||
func(parser AuxDataParser) error { | ||
return parser.InlineParseCustomData(resp) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
needs an update on the litd side if we are going to support it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚢
54736a0
to
5e45f47
Compare
Thanks for the reviews. Testing this in litd will involve updating all projects to compile time |
We should also expose the custom data of the HTLC in the forwarding history RPC (if easily possible). See lightninglabs/taproot-assets#1408 |
This commit adds the custom channel data for closed channels which represents the initial funding state as well as the final balances at closing time.
The pending force close and pending waiting close channels didn't have their custom channel data populated yet.
Unfortunately, this turned out to be non-trivial. We don't have access to the HTLCs custom data in the forwarding history. Need to think of another approach there, so going ahead with the PR as is.
|
This PR adds the custom channel data for closed channels which
represents the initial funding state as well as the final balances at
closing time.