multi: bump to latest lnd/tapd, assert close chan data #1017
+271
−26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guggero
force-pushed
the
closedchannel-data
branch
from
7bdd35f to
e898a32
Compare
guggero
force-pushed
the
closedchannel-data
branch
from
e898a32 to
d95e34f
Compare
gijswijs
reviewed
Mar 28, 2025
| return fmt.Errorf("expected asset ID %s, got %s", | ||
| assetIDStr, a.AssetInfo.AssetGenesis.AssetID) | ||
| assetID := mintedAsset.AssetGenesis.AssetId | ||
| if !haveFundingAsset(a, assetID) { |
There was a problem hiding this comment.
For my understanding:
In the old situation there could only be one type of AssetID as the funding asset of a custom channel. But in the new situation we can have funding assets with different AssetID's and we check if one of them is the assetID we expect.
guggero
force-pushed
the
closedchannel-data
branch
2 times, most recently
from
c9ffb84 to
18fb369
Compare
guggero
force-pushed
the
closedchannel-data
branch
from
18fb369 to
7c8b3f4
Compare
|
The |
This fixes an issue where the lnd sweeper sometimes doesn't sweep all timeout HTLCs in a single sweep TX. If that happens, we just need to wait for an additional one.
guggero
force-pushed
the
closedchannel-data
branch
from
0491947 to
8c43bfe
Compare
|
Yesss, itests are stable now. cc @GeorgeTsagk |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on lightningnetwork/lnd#9504.Depends on lightninglabs/taproot-assets#1441.Serves as validation code for the changes in lightningnetwork/lnd#9504.
Also fixes #940.