Test context guard optimization #9401
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This bump includes a fix which prevents attribute value quoting if the value string contains a newline character. This is so that if we call spew.DumpS(), the output will stay nicely formatted. The update also includes a couple more Hex helpers which we can make use of now.
Update to use the latest version of the GoroutineManager which takes a context via the `Go` method instead of the constructor.
So that we dont have to remember to add the `FSM(%v)` prefix each time we write a log line.
|
Important Review skippedAuto reviews are limited to specific labels. 🏷️ Labels to auto review (1)
Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
starius
force-pushed
the
test-context-guard-optimization2
branch
2 times, most recently
from
dd897e2 to
9fbed44
Compare
This commit updates the fn dep to the version containing the updates to the ContextGuard implementation. Only the htlcswitch/link uses the guard at the moment so this is updated to make use of the new implementation.
starius
force-pushed
the
test-context-guard-optimization2
branch
from
9fbed44 to
16ea6cb
Compare
ellemouton
reviewed
Jan 6, 2025
There was a problem hiding this comment.
Thanks @starius 🙏
Once the referenced PR is in, let's rebase and kick this off again so that we can get those required itests to run
| @@ -215,3 +215,5 @@ go 1.22.6 | |||
| retract v0.0.2 | |||
|
|
|||
| replace github.com/btcsuite/btclog/v2 => github.com/ellemouton/btclog/v2 v2.0.0-20241210110018-997ee6596623 | |||
|
|
|||
| replace github.com/lightningnetwork/lnd/fn/v2 => github.com/starius/lnd/fn/v2 v2.0.7-optcg | |||
There was a problem hiding this comment.
for future: it might be easier just to point to the commit hash in your repo. That way it is also easy to check that it matches the commit hash in the other PR. Then you dont need to push your own tag :)
starius
force-pushed
the
test-context-guard-optimization2
branch
from
16ea6cb to
ebe0896
Compare
starius
force-pushed
the
test-context-guard-optimization2
branch
from
ebe0896 to
f134e40
Compare
|
Pushed a new tag |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Description
This PR was created to test #9361
I also included #9342 to fix compilation errors.
Steps to Test
Pull Request Checklist
Testing
Code Style and Documentation
[skip ci]in the commit message for small changes.📝 Please see our Contribution Guidelines for further guidance.