ADS131M08-Q1 driver#10
Merged
Merged
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces the PDU Mk1 firmware, including drivers for SPI, GPIO, UART, and the ADS131M08-Q1 ADC. The review identified critical bugs in SPI interrupt handlers where incorrect semaphores were signaled for hspi1. Feedback also focused on the ADC driver, recommending the replacement of inefficient vTaskDelay calls for chip-select timing, the use of byte shifts instead of unsafe pointer casting for 24-bit data, and a more robust sign-extension implementation. Corrections to mismatched peripheral names in code comments were also requested.
Lakshay983
approved these changes
May 10, 2026
Lakshay983
left a comment
Lakshay983
left a comment
There was a problem hiding this comment.
good if this branch is tested on hardware
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The stuff from PR #7, but hopefully into the right branch this time...