Skip to content

fix(app): store Windows favicon as regular file#2526

Merged
superm1 merged 1 commit into
mainfrom
fix/windows-favicon-real-file
Jul 2, 2026
Merged

fix(app): store Windows favicon as regular file#2526
superm1 merged 1 commit into
mainfrom
fix/windows-favicon-real-file

Conversation

@fl0rianr

@fl0rianr fl0rianr commented Jul 1, 2026

Copy link
Copy Markdown
Collaborator

Fixes #2521.

The Windows Tauri host embeds src/app/assets/favicon.ico with include_bytes!. This file was tracked as a Git symlink, which can break on Windows checkouts without symlink support and cause Image::from_bytes to fail.

This removes the symlink and commits the icon as a regular file.

Verified:

  • git mode changed from 120000 to 100644
  • src/app/assets/favicon.ico matches docs/assets/favicon.ico"

Fixes #2521.

Co-authored-by: blackdeathdrow <47447306+blackdeathdrow@users.noreply.github.com>
@superm1 superm1 added this pull request to the merge queue Jul 2, 2026
Merged via the queue into main with commit d67a9d7 Jul 2, 2026
134 of 135 checks passed
@superm1 superm1 deleted the fix/windows-favicon-real-file branch July 2, 2026 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

app bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Lemonade App (lemonade-app.exe) crashes on startup with favicon error

2 participants