fix(app): replace broken favicon.ico symlink with a real file#2524
Closed
blackdeathdrow wants to merge 1 commit into
Closed
fix(app): replace broken favicon.ico symlink with a real file#2524blackdeathdrow wants to merge 1 commit into
blackdeathdrow wants to merge 1 commit into
Conversation
src/app/assets/favicon.ico was a broken symlink stored as a plain text file containing '../../../docs/assets/favicon.ico' instead of actual icon data. This caused Tauri's Image::from_bytes to fail with format detection error, crashing lemonade-app.exe on startup. Replaced with a copy of docs/assets/favicon.ico (126745 bytes).
Collaborator
|
Thanks @blackdeathdrow! But closing this one in favor of #2526 since this PR has a full and complete CI fail and I took your fix correctly into this new PR with you as a co-author. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
src/app/assets/favicon.icowas a Git symlink stored as a plain text file containing../../../docs/assets/favicon.ico(32 bytes) instead of actual icon data. On Windows, Git cannot create proper symlinks without Developer Mode enabled, so the file ends up as broken text.The Rust code
include_bytes!("../../assets/favicon.ico")embeds this broken file at compile time, causingtauri::image::Image::from_bytesto fail with "The image format could not be determined". The Tauri desktop app (lemonade-app.exe) then crashes on startup.Replace the broken file with a copy of
docs/assets/favicon.ico(126745 bytes).Closes #2521.