Theme updates#1673
Conversation
sofiageo
force-pushed
the
sofiageo/light-theme-update
branch
from
aec2965 to
1cab29d
Compare
I put a current screenshot into Claude Design and here's what it came back with ☝️ I like the 1st and 3rd options on the bottom row pretty well. Curious what you think? I agree with some of the overall suggestions, like that the stats bar shouldn't be the boldest color in the theme. |
jeremyfowers
left a comment
jeremyfowers
left a comment
There was a problem hiding this comment.
Please see comments - these are my suggestions for getting the existing theme release-ready.
I'm also intrigued by the Claude Design suggestions that give some more depth to the design. LMK what you think there.
|
I'll start reading and fix these tomorrow. Most of the work I managed to do was to transfer the colors to CSS variables and fixing the serious color issues, and I only made the PR because it was a lot of manual work and it will be hard to merge with many conflicts. But I will try to finish this tomorrow so it's working as expected. |
Yes, 4 and 5 look great. I will see if we can use these colors in the current theme. |
jeremyfowers
left a comment
jeremyfowers
left a comment
There was a problem hiding this comment.
I only made the PR because it was a lot of manual work and it will be hard to merge with many conflicts
I see! Feel free to merge this PR and then address comments in a follow up.
sofiageo
force-pushed
the
sofiageo/light-theme-update
branch
from
1cab29d to
e606946
Compare
2 participants
This PR extracts more colors into CSS variables. Fixes some issues with the current light theme. The important part is to have the necessary CSS variables in order to be able to override them in different themes.
When it is merged, I will try to create a different light theme (something similar to vscode github light theme) and convert the current light theme to "lemonade theme".