Skip to content

Conversation

@ManuelHu
Copy link
Contributor

@ManuelHu ManuelHu commented Jul 15, 2025

  • store the global position of all germanium detectors into a detector_origins table
    • for this, some code from vertex confinement is moved out to RMGNavigationTools
  • in post-processing, deduplicate tables with information that is generate on all threads (such as process id to name mappings, detector coordinates)
  • convert these deduplicated tables to LH5 structs (when reshaping is on, flat output keeps tables for these):
├── detector_origins · struct{det1,det2} 
│   ├── det1 · struct{xloc,yloc,zloc} 
│   │   ├── xloc · real 
│   │   ├── yloc · real 
│   │   └── zloc · real 
│   └── det2 · struct{xloc,yloc,zloc} 
│       ├── xloc · real 
│       ├── yloc · real 
│       └── zloc · real 

@ManuelHu ManuelHu force-pushed the lh5-struct-deduplicate branch from fe80635 to 8f3031f Compare July 15, 2025 19:27
@ManuelHu ManuelHu changed the title Lh5 struct deduplicate LH5 struct deduplicate Jul 15, 2025
@ManuelHu ManuelHu force-pushed the lh5-struct-deduplicate branch from 8f3031f to af8b5fc Compare July 16, 2025 15:06
@ManuelHu ManuelHu marked this pull request as ready for review July 18, 2025 13:14
@gipert gipert added output geometry python-wrapper remage python wrapper and infrastructure labels Jul 28, 2025
@gipert
Copy link
Member

gipert commented Jul 28, 2025

Very nice! I had a quick look and it seems good to go to me.

Could you update PR title and description with more details about the changes?

@ManuelHu ManuelHu changed the title LH5 struct deduplicate store detector global coordinates, deduplicate auxiliary tables and convert to LH5 structs Jul 28, 2025
@ManuelHu ManuelHu force-pushed the lh5-struct-deduplicate branch from af8b5fc to 6b3645d Compare July 29, 2025 09:16
@gipert
Copy link
Member

gipert commented Jul 29, 2025

Can we merge this? I want to update #435.

@ManuelHu ManuelHu merged commit 6cb8b98 into legend-exp:main Jul 29, 2025
6 of 7 checks passed
@ManuelHu ManuelHu deleted the lh5-struct-deduplicate branch July 29, 2025 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

geometry output python-wrapper remage python wrapper and infrastructure

Projects

None yet

Development

Successfully merging this pull request may close these issues.

post-process processes table after merging Add location of germanium detectors in global coordinates to output

2 participants