Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Task - 1 Done by Tahseen Alaa. #2

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Task - 1 Done by Tahseen Alaa. #2

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
87 changes: 87 additions & 0 deletions Solutions/Task - 1/assets/css/style.css
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,87 @@
html, body {
margin: 0;
padding: 0;
}

header {
margin: 50px auto auto 50px;
text-align: center;
left: 20%;
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

header
you don't need just remote it left: 20%. Also you can use short hand property for margin: 50px auto;


section {
text-align: center;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

useless just remote it

}

h1 {
font-size: 50px;
font-weight: bold;
color: #4F5362;
}

h4 {
color: #646568;
font-weight: normal;
}

.backSpace {
background-color: #fff;
width: 750px;
height: 250px;
position: relative;
margin: 100px auto auto 50px;
border-radius: 3px;
box-shadow: 10px 10px 50px 30px #EFF0F4;
padding: 50px 50px 50px 50px;
left: 27%;
text-align: center;
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

backSpace
as you can see in the image below, your layout is broken!! the reason is left: 27% do you know the purpose of left property? you can't use it everywhere be careful with that. Remove position, text-align Also, use shorthand for margin: 100px auto 50px and padding: 50px
screen shot 2018-03-29 at 22 51 43


.container {
display: flex;
justify-content: space-around;
flex-wrap: wrap;
}

.btn {
text-align: center;
padding: 12px 20px 12px 20px;
margin: 10px 5px 10px 5px;
border: 1px solid transparent;
border-radius: 5px;
text-align: center;
color: #111;
background-color: #EFF0F4;
}

.btn1, .btn2, .btn6, .btn11 {
background-color: #1ECDE2;
color: #fff;
}

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why you are using multiple classes for active buttons ?
you use an .active class instead of these.btn1, .btn2, .btn6, .btn11 and then use it in your button tags!

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought I will need it later, and forget to delete them.


.checkOutButtons {
display: flex;
justify-content: center;
margin-top: 75px;
}

.btnGoBack {
padding-right: 50px;
}

.btnGoBack button, .btnProcees button {
text-transform: uppercase;
border-radius: 30px;
border: 2px solid #EFF0F4;
background-color: transparent;
color: #b8b9bc;
padding: 10px 30px 10px 30px;
font-weight: bold;
font-size: 14px;
}

.btnProcees button {
background-color: #AED581;
color: #fff;
}
118 changes: 118 additions & 0 deletions Solutions/Task - 1/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,118 @@
<!DOCTYPE html>
<html lang="en">
<head>
<meta charset="UTF-8">
<meta name="viewport" content="width=device-width, initial-scale=1.0">
<meta http-equiv="X-UA-Compatible" content="ie=edge">
<title>Taski - 1</title>

<link rel="stylesheet" href="assets/css/style.css">
</head>
<body>


<!-- START page Title -->
<header>
<div class="heading">
<h1>Select your preferred languages</h1>
</div>

<div class="subtitle">
<h4>This step allows us to match opponent & select problems for you, that can be <br>
solved efficiently and specifically with the languages selected be you.</h4>
</div>
</header>
<!-- END page Title -->



<section>
<div class="backSpace">

<!-- START Blocks Buttons -->
<div class="container">
<div class="">
<button class="btn btn1">C</button>
</div>

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove all <div class=""> since they don't have class!

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the whole code need minify before deploy as production.
thanks for the review.
I fixed all bugs.

<div class="">
<button class="btn btn2">c++</button>
</div>

<div class="">
<button class="btn btn3">java</button>
</div>

<div class="">
<button class="btn btn4">c#</button>
</div>

<div class="">
<button class="btn btn5">haskell</button>
</div>

<div class="">
<button class="btn btn6">python</button>
</div>

<div class="">
<button class="btn btn7">javascript</button>
</div>

<div class="">
<button class="btn btn8">rust</button>
</div>

<div class="">
<button class="btn btn9">lisb</button>
</div>

<div class="">
<button class="btn btn10">objective c</button>
</div>

<div class="">
<button class="btn btn11">perl</button>
</div>

<div class="">
<button class="btn btn12">scala</button>
</div>

<div class="">
<button class="btn btn13">pascal</button>
</div>

<div class="">
<button class="btn btn14">ruby</button>
</div>

<div class="">
<button class="btn btn15">clojure</button>
</div>

<div class="">
<button class="btn btn16">r</button>
</div>
</div>
<!-- END Blocks Buttons -->


<!-- START Submit buttons -->
<div class="checkOutButtons">
<div class="btnGoBack">
<button>go back</button>
</div>

<div class="btnProcees">
<button>proceed</button>
</div>
</div>
<!-- END Submit buttons -->



</div>
</section>
</body>
</html>