-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Task - 1 Done by Tahseen Alaa. #2
base: master
Are you sure you want to change the base?
Conversation
margin: 50px auto auto 50px; | ||
text-align: center; | ||
left: 20%; | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
header
you don't need just remote it left: 20%
. Also you can use short hand property for margin: 50px auto;
} | ||
|
||
section { | ||
text-align: center; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
useless just remote it
padding: 50px 50px 50px 50px; | ||
left: 27%; | ||
text-align: center; | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
background-color: #1ECDE2; | ||
color: #fff; | ||
} | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why you are using multiple classes for active buttons ?
you use an .active
class instead of these.btn1, .btn2, .btn6, .btn11
and then use it in your button tags!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I thought I will need it later, and forget to delete them.
<div class=""> | ||
<button class="btn btn1">C</button> | ||
</div> | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove all <div class="">
since they don't have class!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the whole code need minify before deploy as production.
thanks for the review.
I fixed all bugs.
Task - 1 Done by Tahseen Alaa.
Added to Solutions Branch.