[12.x] Ensure custom validation messages work for the File rule #57656
+31
−3
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using the File rule with custom messages for multiple files in the same request, the wrong message can appear. The generic file message is shown instead of the sub-rule messages (max, size, etc.). - This appears to be introduced by my previous PR - #57356
This PR resolves that and adds a test to prevent regression - I believe only File is affected because it wraps multiple sub-rules and has a default class-based file message. I've tried to same with Password, etc, and have been unable to get it to happen.
The alternative- if this feels too narrow could be:
Any suggestions, please let me know 🫡 - Thanks!!