[12.x] Ensure custom validation messages work for the File rule (#57656)

* init

* be more Laravel-esque

* cs

* Update FileValidationTest.php

* no need to be strict, be like elsewhere.

Author: jackbayliss

src/Illuminate/Validation/Concerns/FormatsMessages.php

@@ -103,10 +103,12 @@ protected function getFromLocalArray($attribute, $lowerRule, $source = null)
 
         $keys = ["{$attribute}.{$lowerRule}", $lowerRule, $attribute];
 
-        $shortRule = "{$attribute}.".Str::snake(class_basename($lowerRule));
+        if ($this->getAttributeType($attribute) !== 'file') {
+            $shortRule = "{$attribute}.".Str::snake(class_basename($lowerRule));
 
-        if (! in_array($shortRule, $keys)) {
-            $keys[] = $shortRule;
+            if (! in_array($shortRule, $keys)) {
+                $keys[] = $shortRule;
+            }
         }
 
         // First we will check for a custom message for an attribute specific rule

tests/Integration/Validation/Rules/FileValidationTest.php

@@ -51,4 +51,30 @@ public function test_it_can_validate_attribute_as_array_when_validation_should_f
             0 => __('validation.mimetypes', ['attribute' => sprintf('files.%s', str_replace('_', ' ', $attribute)), 'values' => implode(', ', $mimes)]),
         ], $validator->messages()->all());
     }
+
+    public function test_file_custom_validation_messages()
+    {
+        $validator = Validator::make(
+            [
+                'one' => UploadedFile::fake()->create('photo', 1000),
+                'two' => 'not-a-file',
+            ],
+            [
+                'one' => [File::default()->max(50)],
+                'two' => [File::default()->max(50)],
+            ],
+            [
+                'one.max' => 'File one is too large',
+                'one.file' => 'File one is not a file',
+                'two.max' => 'File two is too large',
+                'two.file' => 'File two is not a file',
+            ]);
+
+        $this->assertTrue($validator->fails());
+
+        $this->assertSame([
+            'File one is too large',
+            'File two is not a file',
+        ], $validator->messages()->all());
+    }
 }