Skip to content

change the string names generated for rc128 and rc96 in BuiltinName #2057

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: starkware-development
Choose a base branch
from
Open

change the string names generated for rc128 and rc96 in BuiltinName #2057

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 12 additions & 12 deletions vm/src/types/builtin_name.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,8 @@
// Internal constants
const OUTPUT_BUILTIN_NAME: &str = "output";
const HASH_BUILTIN_NAME: &str = "pedersen";
const RANGE_CHECK_BUILTIN_NAME: &str = "range_check";
const RANGE_CHECK_96_BUILTIN_NAME: &str = "range_check96";
const RANGE_CHECK_BUILTIN_BITS_128_NAME: &str = "range_check";
const RANGE_CHECK_BUILTIN_BITS_96_NAME: &str = "range_check96";
const SIGNATURE_BUILTIN_NAME: &str = "ecdsa";
const BITWISE_BUILTIN_NAME: &str = "bitwise";
const EC_OP_BUILTIN_NAME: &str = "ec_op";
Expand All @@ -19,8 +19,8 @@

const OUTPUT_BUILTIN_NAME_WITH_SUFFIX: &str = "output_builtin";
const HASH_BUILTIN_NAME_WITH_SUFFIX: &str = "pedersen_builtin";
const RANGE_CHECK_BUILTIN_NAME_WITH_SUFFIX: &str = "range_check_builtin";
const RANGE_CHECK_96_BUILTIN_NAME_WITH_SUFFIX: &str = "range_check96_builtin";
const RANGE_CHECK_BUILTIN_BITS_128_NAME_WITH_SUFFIX: &str = "range_check_builtin_bits_128";
const RANGE_CHECK_BUILTIN_BITS_96_NAME_WITH_SUFFIX: &str = "range_check_builtin_bits_96";
const SIGNATURE_BUILTIN_NAME_WITH_SUFFIX: &str = "ecdsa_builtin";
const BITWISE_BUILTIN_NAME_WITH_SUFFIX: &str = "bitwise_builtin";
const EC_OP_BUILTIN_NAME_WITH_SUFFIX: &str = "ec_op_builtin";
Expand Down Expand Up @@ -64,15 +64,15 @@
pub fn to_str_with_suffix(self) -> &'static str {
match self {
BuiltinName::output => OUTPUT_BUILTIN_NAME_WITH_SUFFIX,
BuiltinName::range_check => RANGE_CHECK_BUILTIN_NAME_WITH_SUFFIX,
BuiltinName::range_check => RANGE_CHECK_BUILTIN_BITS_128_NAME_WITH_SUFFIX,
BuiltinName::pedersen => HASH_BUILTIN_NAME_WITH_SUFFIX,
BuiltinName::ecdsa => SIGNATURE_BUILTIN_NAME_WITH_SUFFIX,
BuiltinName::keccak => KECCAK_BUILTIN_NAME_WITH_SUFFIX,
BuiltinName::bitwise => BITWISE_BUILTIN_NAME_WITH_SUFFIX,
BuiltinName::ec_op => EC_OP_BUILTIN_NAME_WITH_SUFFIX,
BuiltinName::poseidon => POSEIDON_BUILTIN_NAME_WITH_SUFFIX,
BuiltinName::segment_arena => SEGMENT_ARENA_BUILTIN_NAME_WITH_SUFFIX,
BuiltinName::range_check96 => RANGE_CHECK_96_BUILTIN_NAME_WITH_SUFFIX,
BuiltinName::range_check96 => RANGE_CHECK_BUILTIN_BITS_96_NAME_WITH_SUFFIX,
BuiltinName::add_mod => ADD_MOD_BUILTIN_NAME_WITH_SUFFIX,
BuiltinName::mul_mod => MUL_MOD_BUILTIN_NAME_WITH_SUFFIX,
}
Expand All @@ -92,15 +92,15 @@
pub fn to_str(self) -> &'static str {
match self {
BuiltinName::output => OUTPUT_BUILTIN_NAME,
BuiltinName::range_check => RANGE_CHECK_BUILTIN_NAME,
BuiltinName::range_check => RANGE_CHECK_BUILTIN_BITS_128_NAME,
BuiltinName::pedersen => HASH_BUILTIN_NAME,
BuiltinName::ecdsa => SIGNATURE_BUILTIN_NAME,
BuiltinName::keccak => KECCAK_BUILTIN_NAME,
BuiltinName::bitwise => BITWISE_BUILTIN_NAME,
BuiltinName::ec_op => EC_OP_BUILTIN_NAME,
BuiltinName::poseidon => POSEIDON_BUILTIN_NAME,
BuiltinName::segment_arena => SEGMENT_ARENA_BUILTIN_NAME,
BuiltinName::range_check96 => RANGE_CHECK_96_BUILTIN_NAME,
BuiltinName::range_check96 => RANGE_CHECK_BUILTIN_BITS_96_NAME,
BuiltinName::add_mod => ADD_MOD_BUILTIN_NAME,
BuiltinName::mul_mod => MUL_MOD_BUILTIN_NAME,
}
Expand All @@ -121,15 +121,15 @@
pub fn from_str_with_suffix(suffixed_str: &str) -> Option<Self> {
match suffixed_str {
OUTPUT_BUILTIN_NAME_WITH_SUFFIX => Some(BuiltinName::output),
RANGE_CHECK_BUILTIN_NAME_WITH_SUFFIX => Some(BuiltinName::range_check),
RANGE_CHECK_BUILTIN_BITS_128_NAME_WITH_SUFFIX => Some(BuiltinName::range_check),
HASH_BUILTIN_NAME_WITH_SUFFIX => Some(BuiltinName::pedersen),
SIGNATURE_BUILTIN_NAME_WITH_SUFFIX => Some(BuiltinName::ecdsa),
KECCAK_BUILTIN_NAME_WITH_SUFFIX => Some(BuiltinName::keccak),
BITWISE_BUILTIN_NAME_WITH_SUFFIX => Some(BuiltinName::bitwise),
EC_OP_BUILTIN_NAME_WITH_SUFFIX => Some(BuiltinName::ec_op),
POSEIDON_BUILTIN_NAME_WITH_SUFFIX => Some(BuiltinName::poseidon),
SEGMENT_ARENA_BUILTIN_NAME_WITH_SUFFIX => Some(BuiltinName::segment_arena),
RANGE_CHECK_96_BUILTIN_NAME_WITH_SUFFIX => Some(BuiltinName::range_check96),
RANGE_CHECK_BUILTIN_BITS_96_NAME_WITH_SUFFIX => Some(BuiltinName::range_check96),

Check warning on line 132 in vm/src/types/builtin_name.rs

View check run for this annotation

Codecov / codecov/patch

vm/src/types/builtin_name.rs#L132 

Added line #L132 was not covered by tests
ADD_MOD_BUILTIN_NAME_WITH_SUFFIX => Some(BuiltinName::add_mod),
MUL_MOD_BUILTIN_NAME_WITH_SUFFIX => Some(BuiltinName::mul_mod),
_ => None,
Expand All @@ -153,15 +153,15 @@
pub fn from_str(str: &str) -> Option<Self> {
match str {
OUTPUT_BUILTIN_NAME => Some(BuiltinName::output),
RANGE_CHECK_BUILTIN_NAME => Some(BuiltinName::range_check),
RANGE_CHECK_BUILTIN_BITS_128_NAME => Some(BuiltinName::range_check),
HASH_BUILTIN_NAME => Some(BuiltinName::pedersen),
SIGNATURE_BUILTIN_NAME => Some(BuiltinName::ecdsa),
KECCAK_BUILTIN_NAME => Some(BuiltinName::keccak),
BITWISE_BUILTIN_NAME => Some(BuiltinName::bitwise),
EC_OP_BUILTIN_NAME => Some(BuiltinName::ec_op),
POSEIDON_BUILTIN_NAME => Some(BuiltinName::poseidon),
SEGMENT_ARENA_BUILTIN_NAME => Some(BuiltinName::segment_arena),
RANGE_CHECK_96_BUILTIN_NAME => Some(BuiltinName::range_check96),
RANGE_CHECK_BUILTIN_BITS_96_NAME => Some(BuiltinName::range_check96),

Check warning on line 164 in vm/src/types/builtin_name.rs

View check run for this annotation

Codecov / codecov/patch

vm/src/types/builtin_name.rs#L164 

Added line #L164 was not covered by tests
ADD_MOD_BUILTIN_NAME => Some(BuiltinName::add_mod),
MUL_MOD_BUILTIN_NAME => Some(BuiltinName::mul_mod),
_ => None,
Expand Down
Loading