Skip to content

change the string names generated for rc128 and rc96 in BuiltinName #2057

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: starkware-development
Choose a base branch
from
Open

change the string names generated for rc128 and rc96 in BuiltinName #2057

wants to merge 1 commit into from

Conversation

ohad-nir-starkware
Copy link
Collaborator

TITLE

Description

Description of the pull request changes and motivation.

Checklist

  • Linked to Github Issue
  • Unit tests added
  • Integration tests added.
  • This change requires new documentation.
    • Documentation has been added/updated.
    • CHANGELOG has been updated.

@ohad-nir-starkware ohad-nir-starkware self-assigned this Apr 7, 2025
@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 7, 2025 

**Hyper Thereading Benchmark results**




hyperfine -r 2 -n "hyper_threading_main threads: 1" 'RAYON_NUM_THREADS=1 ./hyper_threading_main' -n "hyper_threading_pr threads: 1" 'RAYON_NUM_THREADS=1 ./hyper_threading_pr'
Benchmark 1: hyper_threading_main threads: 1
  Time (mean ± σ):     26.266 s ±  0.024 s    [User: 25.511 s, System: 0.753 s]
  Range (min … max):   26.249 s … 26.284 s    2 runs
 
Benchmark 2: hyper_threading_pr threads: 1
  Time (mean ± σ):     26.670 s ±  0.060 s    [User: 25.905 s, System: 0.763 s]
  Range (min … max):   26.627 s … 26.713 s    2 runs
 
Summary
  hyper_threading_main threads: 1 ran
    1.02 ± 0.00 times faster than hyper_threading_pr threads: 1




hyperfine -r 2 -n "hyper_threading_main threads: 2" 'RAYON_NUM_THREADS=2 ./hyper_threading_main' -n "hyper_threading_pr threads: 2" 'RAYON_NUM_THREADS=2 ./hyper_threading_pr'
Benchmark 1: hyper_threading_main threads: 2
  Time (mean ± σ):     14.640 s ±  0.034 s    [User: 25.752 s, System: 0.760 s]
  Range (min … max):   14.615 s … 14.664 s    2 runs
 
Benchmark 2: hyper_threading_pr threads: 2
  Time (mean ± σ):     14.878 s ±  0.001 s    [User: 25.950 s, System: 0.823 s]
  Range (min … max):   14.878 s … 14.879 s    2 runs
 
Summary
  hyper_threading_main threads: 2 ran
    1.02 ± 0.00 times faster than hyper_threading_pr threads: 2




hyperfine -r 2 -n "hyper_threading_main threads: 4" 'RAYON_NUM_THREADS=4 ./hyper_threading_main' -n "hyper_threading_pr threads: 4" 'RAYON_NUM_THREADS=4 ./hyper_threading_pr'
Benchmark 1: hyper_threading_main threads: 4
  Time (mean ± σ):     10.553 s ±  0.621 s    [User: 37.790 s, System: 0.912 s]
  Range (min … max):   10.114 s … 10.992 s    2 runs
 
Benchmark 2: hyper_threading_pr threads: 4
  Time (mean ± σ):     11.038 s ±  0.174 s    [User: 38.623 s, System: 1.005 s]
  Range (min … max):   10.915 s … 11.161 s    2 runs
 
Summary
  hyper_threading_main threads: 4 ran
    1.05 ± 0.06 times faster than hyper_threading_pr threads: 4




hyperfine -r 2 -n "hyper_threading_main threads: 6" 'RAYON_NUM_THREADS=6 ./hyper_threading_main' -n "hyper_threading_pr threads: 6" 'RAYON_NUM_THREADS=6 ./hyper_threading_pr'
Benchmark 1: hyper_threading_main threads: 6
  Time (mean ± σ):     10.247 s ±  0.305 s    [User: 38.103 s, System: 0.927 s]
  Range (min … max):   10.031 s … 10.462 s    2 runs
 
Benchmark 2: hyper_threading_pr threads: 6
  Time (mean ± σ):     10.905 s ±  0.026 s    [User: 39.272 s, System: 1.007 s]
  Range (min … max):   10.886 s … 10.923 s    2 runs
 
Summary
  hyper_threading_main threads: 6 ran
    1.06 ± 0.03 times faster than hyper_threading_pr threads: 6




hyperfine -r 2 -n "hyper_threading_main threads: 8" 'RAYON_NUM_THREADS=8 ./hyper_threading_main' -n "hyper_threading_pr threads: 8" 'RAYON_NUM_THREADS=8 ./hyper_threading_pr'
Benchmark 1: hyper_threading_main threads: 8
  Time (mean ± σ):     10.207 s ±  0.134 s    [User: 38.332 s, System: 0.958 s]
  Range (min … max):   10.113 s … 10.302 s    2 runs
 
Benchmark 2: hyper_threading_pr threads: 8
  Time (mean ± σ):     10.750 s ±  0.246 s    [User: 39.085 s, System: 1.033 s]
  Range (min … max):   10.576 s … 10.924 s    2 runs
 
Summary
  hyper_threading_main threads: 8 ran
    1.05 ± 0.03 times faster than hyper_threading_pr threads: 8




hyperfine -r 2 -n "hyper_threading_main threads: 16" 'RAYON_NUM_THREADS=16 ./hyper_threading_main' -n "hyper_threading_pr threads: 16" 'RAYON_NUM_THREADS=16 ./hyper_threading_pr'
Benchmark 1: hyper_threading_main threads: 16
  Time (mean ± σ):     10.214 s ±  0.023 s    [User: 38.720 s, System: 1.021 s]
  Range (min … max):   10.198 s … 10.230 s    2 runs
 
Benchmark 2: hyper_threading_pr threads: 16
  Time (mean ± σ):     10.539 s ±  0.096 s    [User: 39.832 s, System: 1.099 s]
  Range (min … max):   10.471 s … 10.607 s    2 runs
 
Summary
  hyper_threading_main threads: 16 ran
    1.03 ± 0.01 times faster than hyper_threading_pr threads: 16

@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 7, 2025

Benchmark Results for unmodified programs 🚀

Command Mean [s] Min [s] Max [s] Relative
base big_factorial 2.112 ± 0.011 2.095 2.128 1.00 ± 0.01
head big_factorial 2.106 ± 0.012 2.095 2.134 1.00
Command Mean [s] Min [s] Max [s] Relative
base big_fibonacci 2.044 ± 0.013 2.032 2.066 1.01 ± 0.01
head big_fibonacci 2.033 ± 0.015 2.020 2.061 1.00
Command Mean [s] Min [s] Max [s] Relative
base blake2s_integration_benchmark 7.850 ± 0.091 7.720 8.035 1.01 ± 0.02
head blake2s_integration_benchmark 7.742 ± 0.118 7.636 7.979 1.00
Command Mean [s] Min [s] Max [s] Relative
base compare_arrays_200000 2.161 ± 0.011 2.146 2.182 1.00
head compare_arrays_200000 2.161 ± 0.008 2.150 2.176 1.00 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
base dict_integration_benchmark 1.414 ± 0.012 1.398 1.439 1.00
head dict_integration_benchmark 1.424 ± 0.013 1.411 1.453 1.01 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
base field_arithmetic_get_square_benchmark 1.227 ± 0.012 1.206 1.249 1.01 ± 0.01
head field_arithmetic_get_square_benchmark 1.213 ± 0.006 1.203 1.222 1.00
Command Mean [s] Min [s] Max [s] Relative
base integration_builtins 7.915 ± 0.100 7.786 8.074 1.02 ± 0.01
head integration_builtins 7.765 ± 0.035 7.705 7.815 1.00
Command Mean [s] Min [s] Max [s] Relative
base keccak_integration_benchmark 8.187 ± 0.078 8.093 8.364 1.02 ± 0.01
head keccak_integration_benchmark 8.064 ± 0.033 8.014 8.119 1.00
Command Mean [s] Min [s] Max [s] Relative
base linear_search 2.177 ± 0.102 2.132 2.466 1.02 ± 0.05
head linear_search 2.143 ± 0.020 2.124 2.194 1.00
Command Mean [s] Min [s] Max [s] Relative
base math_cmp_and_pow_integration_benchmark 1.501 ± 0.009 1.491 1.522 1.00 ± 0.01
head math_cmp_and_pow_integration_benchmark 1.498 ± 0.013 1.487 1.528 1.00
Command Mean [s] Min [s] Max [s] Relative
base math_integration_benchmark 1.445 ± 0.006 1.437 1.455 1.00
head math_integration_benchmark 1.447 ± 0.005 1.438 1.455 1.00 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
base memory_integration_benchmark 1.202 ± 0.006 1.195 1.210 1.00
head memory_integration_benchmark 1.215 ± 0.018 1.197 1.254 1.01 ± 0.02
Command Mean [s] Min [s] Max [s] Relative
base operations_with_data_structures_benchmarks 1.571 ± 0.011 1.552 1.586 1.01 ± 0.01
head operations_with_data_structures_benchmarks 1.561 ± 0.007 1.543 1.567 1.00
Command Mean [ms] Min [ms] Max [ms] Relative
base pedersen 531.2 ± 3.8 523.2 537.8 1.00 ± 0.01
head pedersen 529.0 ± 6.1 513.7 536.6 1.00
Command Mean [ms] Min [ms] Max [ms] Relative
base poseidon_integration_benchmark 629.1 ± 4.3 622.5 636.4 1.00 ± 0.01
head poseidon_integration_benchmark 627.9 ± 5.4 620.4 638.4 1.00
Command Mean [s] Min [s] Max [s] Relative
base secp_integration_benchmark 1.876 ± 0.069 1.846 2.073 1.02 ± 0.04
head secp_integration_benchmark 1.848 ± 0.010 1.840 1.868 1.00
Command Mean [ms] Min [ms] Max [ms] Relative
base set_integration_benchmark 672.2 ± 3.7 663.0 675.7 1.00
head set_integration_benchmark 673.2 ± 8.6 662.9 695.2 1.00 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
base uint256_integration_benchmark 4.293 ± 0.011 4.280 4.312 1.01 ± 0.01
head uint256_integration_benchmark 4.232 ± 0.043 4.185 4.339 1.00

@codecov Codecov
Copy link

codecov bot commented Apr 7, 2025

Codecov Report

Attention: Patch coverage is 75.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 96.53%. Comparing base (b9330cd) to head (b5de6ee).

Files with missing lines Patch % Lines
vm/src/types/builtin_name.rs 75.00% 2 Missing ⚠️
Additional details and impacted files 
@@                  Coverage Diff                   @@
##           starkware-development    #2057   +/-   ##
======================================================
  Coverage                  96.53%   96.53%           
======================================================
  Files                        102      102           
  Lines                      43096    43096           
======================================================
  Hits                       41603    41603           
  Misses                      1493     1493

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@ohad-nir-starkware ohad-nir-starkware removed the request for review from Stavbe April 7, 2025 17:44
@FrancoGiachetta
Copy link
Contributor

FrancoGiachetta commented Apr 7, 2025 •
edited
Loading

Hi @ohad-nir-starkware! Could you explain the purpose of this PR in the description?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@ohad-nir-starkware ohad-nir-starkware

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ohad-nir-starkware @FrancoGiachetta