Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix suffix generating and secret recreate UI state changes #856

Merged
merged 8 commits into from
Sep 3, 2024
+15 −12
Merged

Fix suffix generating and secret recreate UI state changes #856

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
016c24f
Auto generate suffix for binding name
MarekMichali Sep 3, 2024
b242864
Revert auto name suffix
MarekMichali Sep 3, 2024
e12a4ba
Suggest binding name
MarekMichali Sep 3, 2024
ced2c82
Fix state when input blocked
MarekMichali Sep 3, 2024
9164a2d
Bump
MarekMichali Sep 3, 2024
4d3e3e9
Fix disabled input field when applying the restore
MarekMichali Sep 3, 2024
83875a1
Generate suffix when creating another binding
MarekMichali Sep 3, 2024
c73b2db
Fix spacing
MarekMichali Sep 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix disabled input field when applying the restore
@MarekMichali
MarekMichali committed Sep 3, 2024
commit 4d3e3e95d84cc7a195ef8583ac0dc95b328c333a
1 change: 1 addition & 0 deletions ui/src/components/CreateBindingForm.tsx
View file
Original file line number Diff line number Diff line change
@@ -27,6 +27,7 @@ function CreateBindingForm(props: any) {
binding.secret_namespace = "default"

setCreatedBinding(binding);
props.setSecretRestoreButtonPressedState(false);
setError(undefined);
setLoading(false);
return response;
2 changes: 1 addition & 1 deletion ui/src/components/ServiceInstancesDetailsView.tsx
View file
Original file line number Diff line number Diff line change
@@ -86,7 +86,7 @@ const ServiceInstancesDetailsView = forwardRef((props: any, ref) => {
</ui5.Panel>

<ui5.Panel headerLevel="H2" headerText="Create Binding">
<CreateBindingForm secret={secret} binding={binding} onCreate={(binding: ServiceInstanceBinding) => onBindingAdded(binding)} instanceId={props.instance.id} instanceName={props.instance.name} buttonPressed={props.secretRestoreButtonPressed} onSecretRestore={(binding: ServiceInstanceBinding) => onSecretRestore(binding)} />
<CreateBindingForm secret={secret} binding={binding} onCreate={(binding: ServiceInstanceBinding) => onBindingAdded(binding)} instanceId={props.instance.id} instanceName={props.instance.name} setSecretRestoreButtonPressedState={props.setSecretRestoreButtonPressedState} buttonPressed={props.secretRestoreButtonPressed} onSecretRestore={(binding: ServiceInstanceBinding) => onSecretRestore(binding)} />
</ui5.Panel>
</>