Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix suffix generating and secret recreate UI state changes #856

Merged
merged 8 commits into from
Sep 3, 2024
Merged

Fix suffix generating and secret recreate UI state changes #856

merged 8 commits into from
Sep 3, 2024

Conversation

MarekMichali
Copy link
Contributor

@MarekMichali MarekMichali commented Sep 3, 2024 •
edited
Loading

Changes proposed in this pull request:

  • When adding new service binding, both name and secret name have random suffix added
  • Fix binding name field to not be disabled for all instances when switching from an instance that has this field disabled
  • When recreating secret for given Service Binding, suggest Secret Name with the same name as binding

Related issue(s)

See #442

@MarekMichali MarekMichali requested a review from a team as a code owner September 3, 2024 05:36
@kyma-bot kyma-bot added cla: yes Indicates the PR's author has signed the CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Sep 3, 2024
@MarekMichali MarekMichali marked this pull request as draft September 3, 2024 07:27
@kyma-bot kyma-bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 3, 2024
@kyma-bot kyma-bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Sep 3, 2024
@MarekMichali MarekMichali changed the title Auto generate suffix for binding name Fix suffix generating and secret recreate UI state changes Sep 3, 2024
@MarekMichali MarekMichali marked this pull request as ready for review September 3, 2024 07:46
@kyma-bot kyma-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 3, 2024
@kyma-bot kyma-bot added the area/documentation Issues or PRs related to documentation label Sep 3, 2024
@MarekMichali
Copy link
Contributor Author

/hold

@kyma-bot kyma-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 3, 2024
@MarekMichali
Copy link
Contributor Author

/unhold

@kyma-bot kyma-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 3, 2024
@kyma-bot kyma-bot added the lgtm Looks good to me! label Sep 3, 2024
@MarekMichali MarekMichali merged commit 97d84cd into kyma-project:sm-integration Sep 3, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ralikio ralikio ralikio approved these changes

Assignees

@ralikio ralikio

Labels
area/documentation Issues or PRs related to documentation cla: yes Indicates the PR's author has signed the CLA. lgtm Looks good to me! size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MarekMichali @ralikio @kyma-bot