fix(sharing): make project acceptance truthful#1350
Conversation
This stack of pull requests is managed by Graphite. Learn more about stacking. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 36bcc669f7
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
36bcc66 to
bb538bf
Compare
bb538bf to
561be53
Compare
Merge activity
|
561be53 to
02e206f
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 02e206fdef
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| const intervalS = Number(config.sync_interval_s); | ||
| return { | ||
| ...config, | ||
| sync_enabled: true, |
There was a problem hiding this comment.
When the viewer is started with CODEMEM_SYNC_ENABLED=0, this only writes sync_enabled: true to the JSON config, while readCoordinatorSyncConfig reapplies the environment override on every load. Consequently, the advertised restart leaves the runtime disabled with no sync listener or daemon, even though the invite has already been consumed and the response says sync was enabled; detect the active override and provide actionable remediation instead of treating the file write as successful enablement.
Useful? React with 👍 / 👎.
1 participant
Description
Make exact-Project invitation acceptance truthful: token consumption enters pending setup until inviter provisioning converges, recipient sync is enabled, restart requirements are explicit, and safe typed errors reach both recipient and owner surfaces.
Closes codemem-mzj1.
Type of Change
Testing
pnpm run tsc,pnpm run lint,pnpm run test)Core, coordinator API, viewer, worker, and
e2e:project-sharingvalidation passed. The complete stack passedpnpm run checkwith 3,207 tests.Checklist
pnpm run lintpasses for touched files)