-
Notifications
You must be signed in to change notification settings - Fork 1.2k
fix: relaunch workers after endpoint loss #2417
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
twilwa
wants to merge
10
commits into
kunchenguid:main
Choose a base branch
from
twilwa:fm/fm-relaunch-missing-endpoint
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
de324ae
fix: relaunch workers after endpoint loss
twilwa 0757b30
no-mistakes(review): grade missing endpoint verdicts before recreating
twilwa 0c6a27d
fix: relaunch workers after endpoint loss
twilwa facde41
no-mistakes(review): grade missing endpoint verdicts before recreating
twilwa f2d127a
no-mistakes(review): match tmux sessions exactly and cover secondmate…
twilwa 78cf0c5
no-mistakes(review): match the tmux container session exactly on ensure
twilwa 79f0010
no-mistakes(review): grade tmux missing endpoints from one verified i…
twilwa 3059f21
no-mistakes(document): document tmux missing-grade nuance and relaunc…
twilwa 77b80c6
no-mistakes(lint): quote hyphenated lint literals and mark output glo…
twilwa 77b17de
chore: reconcile validated pipeline history
twilwa File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Captain, when a recorded session is gone but a prefix look-alike exists (for example,
smokis missing whilesmokeis live), this barehas-session -t "$session"resolves the look-alike and takes the existing-session branch; the subsequent exact lookup infm_backend_tmux_create_taskthen fails instead of recreating the recorded session. This second definition also overrides the exact-match implementation immediately above, breaking the scenario explicitly exercised intests/fm-backend-tmux-smoke.test.sh:246-288; retain the first definition's-t "=$session"behavior and remove the duplicate.Useful? React with 👍 / 👎.