fix: relaunch workers after endpoint loss - #2417
Conversation
…h recovery verification
* commit 'refs/no-mistakes/recover/01M01V90RNYA80ZT7ZQZH3C7SM': no-mistakes(lint): quote hyphenated lint literals and mark output globals no-mistakes(document): document tmux missing-grade nuance and relaunch recovery verification no-mistakes(review): grade tmux missing endpoints from one verified inspection no-mistakes(review): match the tmux container session exactly on ensure no-mistakes(review): match tmux sessions exactly and cover secondmate recreation no-mistakes(review): grade missing endpoint verdicts before recreating fix: relaunch workers after endpoint loss fix(ci): fail hung Herdr behavior runs in 20 minutes (kunchenguid#2413)
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 77b17de08a
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| if tmux has-session -t "$session" 2>/dev/null; then | ||
| fm_backend_tmux_create_task "$session" "$window" "$worktree" |
There was a problem hiding this comment.
Captain, when a recorded session is gone but a prefix look-alike exists (for example, smok is missing while smoke is live), this bare has-session -t "$session" resolves the look-alike and takes the existing-session branch; the subsequent exact lookup in fm_backend_tmux_create_task then fails instead of recreating the recorded session. This second definition also overrides the exact-match implementation immediately above, breaking the scenario explicitly exercised in tests/fm-backend-tmux-smoke.test.sh:246-288; retain the first definition's -t "=$session" behavior and remove the duplicate.
Useful? React with 👍 / 👎.
1 participant
Summary
Validation
01M01V90RNYA80ZT7ZQZH3C7SM: intent, rebase, review, test, documentation, and lint steps completed; its delivery push alone failed because it targeted upstream instead of the configured fork