Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explicitly set REGISTRY env in ovs-cni jobs #3356

Closed
wants to merge 1 commit into from
Closed

Explicitly set REGISTRY env in ovs-cni jobs #3356

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions github/ci/prow-deploy/files/jobs/k8snetworkplumbingwg/ovs-cni/ovs-cni-postsubmits.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,8 +18,10 @@ postsubmits:
command:
- "/usr/local/bin/runner.sh"
- "/bin/bash"
- "-c"
- "cat $QUAY_PASSWORD | docker login --username $(cat $QUAY_USER) --password-stdin=true quay.io && make docker-build docker-push"
- "-ce"
- |
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cmd format is aligned with "release-ovs-cni" job

cat $QUAY_PASSWORD | docker login --username $(cat $QUAY_USER) --password-stdin=true quay.io
make REGISTRY=quay.io/kubevirt docker-build docker-push
# docker-in-docker needs privileged mode
securityContext:
privileged: true
Expand All @@ -46,7 +48,7 @@ postsubmits:
cat $QUAY_PASSWORD | docker login --username $(cat $QUAY_USER) --password-stdin=true quay.io
# Only push images on tags
COMMIT_TAG=$(git tag --points-at HEAD | head -1)
[ -z "$COMMIT_TAG" ] || make docker-build docker-push IMAGE_TAG=$COMMIT_TAG
[ -z "$COMMIT_TAG" ] || make REGISTRY=quay.io/kubevirt IMAGE_TAG=$COMMIT_TAG docker-build docker-push
# docker-in-docker needs privileged mode
securityContext:
privileged: true