Explicitly set REGISTRY env in ovs-cni jobs #3356
Conversation
This change is required because default registry in the Makefile in the ovs-cni repo was to ghcr.io/k8snetworkplumbingwg. Signed-off-by: Yury Kulazhenkov <[email protected]>
kubevirt-bot
added
the
dco-signoff: yes
|
Hi @ykulazhenkov. Thanks for your PR. PRs from untrusted users cannot be marked as trusted with I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
| - "-c" | ||
| - "cat $QUAY_PASSWORD | docker login --username $(cat $QUAY_USER) --password-stdin=true quay.io && make docker-build docker-push" | ||
| - "-ce" | ||
| - | |
There was a problem hiding this comment.
cmd format is aligned with "release-ovs-cni" job
|
@ykulazhenkov I don't think there is a reason to keep pushing to the old registry. It would be probably better to remove this automation, so we have less stuff to maintain. |
Okay, thanks. Then, I will close this PR. I don't know the exact list of jobs that are no longer needed. Can you submit a PR to remove them? Thanks |
|
@ykulazhenkov sure, fair enough, posted: #3357 |
What this PR does / why we need it:
Explicitly set REGISTRY env in ovs-cni jobs
This change is required because default registry in the Makefile in the ovs-cni repo was changed to ghcr.io/k8snetworkplumbingwg.
Special notes for your reviewer:
Context: k8snetworkplumbingwg/ovs-cni#307
Example of a failed job https://prow.ci.kubevirt.io/view/gs/kubevirt-prow/logs/main-ovs-cni/1781239529819082752
@phoracek Do we want to continue push to quay in addition to GH registry? If yes, then I believe that this patch will fix the push jobs.