-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add lgtm, approve plugins for etcd-io projects #32725
Add lgtm, approve plugins for etcd-io projects #32725
Conversation
This commit will add `lgtm`, `approve` plugins for etcd-io projects which will allow the reviewers to interact with the PRs via chatops to add `lgtm`, `approve` labels Signed-off-by: ArkaSaha30 <[email protected]>
Does it mean that PRs on etcd-io/etcd can be automatically merged if both |
Yes, tide will automatically merge iff both |
/hold |
After looking at tide's configuration, I don't think it will run against test-infra/config/prow/config.yaml Lines 641 to 645 in d0a5eeb
Would having the LGTM label bring value to the team? It may ease the burden on maintainers while managing the open pull requests. |
Correct, we can enable the tide functionality at org or single repo level. If we decide to go with auto-merge, I can add that configuration.
Agree, filtering PRs by |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Discussed during sig-etcd triage meeting, this is an initial step for enabling tide but will not enable auto merge by itself just the pr labelling.
/lgtm
/approve
/unhold |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ArkaSaha30, dims, jmhbnz The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@ArkaSaha30: Updated the
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
This PR will add
lgtm
,approve
plugins for etcd-io projects which will allow the reviewers to interact with the PRs via chatops to addlgtm
,approve
labels.Issue link: etcd-io/etcd#18110