Enable Prow plugins for etcd PRs

[ArkaSaha30]

What would you like to be added?

Plugin enablement for etcd in test-infra.
Suggested plugins to be added:

• cherrypicker: https://prow.k8s.io/command-help#cherrypick
• size: https://github.com/kubernetes/test-infra/blob/master/config/prow/plugins.yaml#L145-L151
• needs-rebase: https://github.com/kubernetes/test-infra/blob/master/config/prow/plugins.yaml#L1661-L1664
• lgtm: https://prow.k8s.io/command-help#lgtm
• approve: https://prow.k8s.io/command-help#approve

Why is this needed?

There are useful Prow plugins that etcd can leverage to minimize manual efforts. One of them is the cherrypicker plugin, which can backport any PR to a specific branch with just a /cherry-pick <branch_name> comment on the PR.
Example: containerd/containerd#10257 (comment)

[ArkaSaha30]

cc @ahrtr @jmhbnz

[ahrtr]

Sounds good to me. /cherry-pick might work for 3.5, but not for 3.4, which has huge difference with main.

[jmhbnz]

Thanks for proposing this @ArkaSaha30. Enabling the cherry pick plugin makes sense to me, please feel free to raise a pr if you have capacity 🙏🏻

[ArkaSaha30]

/assign

[jmhbnz]

Hi @ArkaSaha30 - We raised this at sig-etcd triage meeting, are there any other plugins you suggest we enable or can we close this now?

[ivanvc]

Based on kubernetes/k8s.io#6102 (comment), do we also want to enable tide, lgtm, and approve?

[ArkaSaha30]

Based on kubernetes/k8s.io#6102 (comment), do we also want to enable tide, lgtm, and approve?

Yes! Along with these we can also add 'size' which will label the PRs based on how lengthy it is. WDYT @jmhbnz ?

[jmhbnz]

Based on kubernetes/k8s.io#6102 (comment), do we also want to enable tide, lgtm, and approve?

I am not confident we are ready as a project for tide / auto merging of pull requests. It would be helpful to update this issue with a description of what the proposed plugin does and what impact this would have for the etcd project.

I am happy to enable the pr sizing plugin as that is very low risk.

[jmhbnz]

Discussed during sig-etcd triage meeting, the next major step for this issue is to enable tide for automatically merging pull requests.

This will be a significant change for etcd-io/etcd so we need to discuss this more broadly and ensure the community is ready, next steps would be:

• Discuss at a community meeting - Added agenda item
• Raise a #sig-etcd slack discussion
• Add a detailed comment here with the behavior for tide
• Draft a pull request with a /hold