Make cluster domain configurable via --cluster-domain flag

[framsouza]

The service FQDN was hardcoded to svc.cluster.local, which breaks in clusters using a custom DNS domain (e.g. svc.custom.domain). This was tracked as a TODO in the codebase. This PR is:

• Add --cluster-domain flag to the controller (defaults to cluster.local)
• Convert setServiceStatus from a package-level function to a method on SandboxReconciler so it can read the configured domain
• Add unit test covering both default and custom domain FQDN generation
• Update API type docs to reflect the new configurability

Tests

 % make test-unit
...

--------------------------- generated xml file: /Users/framsouza-personal/agent-sandbox/bin/python-k8s-agent-sandbox-junit.xml ---------------------------
=================================================================== 34 passed in 0.60s ===================================================================
 
% kubectl patch deployment agent-sandbox-controller \
    -n agent-sandbox-system \
    -p '{"spec": {"template": {"spec": {"containers": [{"name": "agent-sandbox-controller", "args": ["--cluster-domain=custom.domain"]}]}}}}'
deployment.apps/agent-sandbox-controller patched
 
% kubectl delete sandbox hello-world                   
sandbox.agents.x-k8s.io "hello-world" deleted from default namespace
 
% kubectl apply -f examples/hello-world-sandbox/
sandbox.agents.x-k8s.io/hello-world created
 
% kubectl get sandbox -o jsonpath='{.items[*].status.serviceFQDN}'
hello-world.default.svc.custom.domain%                                           

[netlify]

✅ Deploy Preview for agent-sandbox canceled.

Name	Link
🔨 Latest commit	d0e35e6
🔍 Latest deploy log	https://app.netlify.com/projects/agent-sandbox/deploys/69c5381befdab00008d5f381

[linux-foundation-easycla]

The committers listed above are authorized under a signed CLA.

• ✅ login: framsouza / name: framsouza (d0e35e6)

[k8s-ci-robot]

Welcome @framsouza!

It looks like this is your first PR to kubernetes-sigs/agent-sandbox 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/agent-sandbox has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

[k8s-ci-robot]

Hi @framsouza. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work.

Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[aditya-shantanu]

/assign @barney-s

[justinsb]

/unassign
/assign

[justinsb]

Thanks for fixing @framsouza !

/approve
/lgtm

[justinsb]

/ok-to-test

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aditya-shantanu, framsouza, justinsb

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [justinsb]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[justinsb]

Looks like you need to run gofmt (I think)

[k8s-ci-robot]

@framsouza: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
presubmit-test-autogen-up-to-date	d0e35e6	link	true	/test presubmit-test-autogen-up-to-date
presubmit-agent-sandbox-lint-go	d0e35e6	link	true	/test presubmit-agent-sandbox-lint-go
presubmit-agent-sandbox-e2e-test	d0e35e6	link	true	/test presubmit-agent-sandbox-e2e-test

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[k8s-ci-robot]

PR needs rebase.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.