Skip to content

Add --cluster-domain flag to make service FQDN configurable#516

Open
kincoy wants to merge 1 commit intokubernetes-sigs:mainfrom
kincoy:feat/configurable-cluster-domain
Open

Add --cluster-domain flag to make service FQDN configurable#516
kincoy wants to merge 1 commit intokubernetes-sigs:mainfrom
kincoy:feat/configurable-cluster-domain

Conversation

@kincoy
Copy link
Copy Markdown

@kincoy kincoy commented Apr 3, 2026

Add --cluster-domain flag (default: cluster.local) to support clusters with non-default DNS domains

@netlify
Copy link
Copy Markdown

netlify bot commented Apr 3, 2026

Deploy Preview for agent-sandbox ready!

Name Link
🔨 Latest commit 9a0aa30
🔍 Latest deploy log https://app.netlify.com/projects/agent-sandbox/deploys/69cfac8973398b0008d8d9a6
😎 Deploy Preview https://deploy-preview-516--agent-sandbox.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@k8s-ci-robot k8s-ci-robot requested review from igooch and justinsb April 3, 2026 12:03
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: kincoy
Once this PR has been reviewed and has the lgtm label, please assign justinsb for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

Hi @kincoy. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work.

Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Apr 3, 2026
@justinsb
Copy link
Copy Markdown
Contributor

justinsb commented Apr 3, 2026

We do have #477, which I think is similar and is just waiting on a gofmt. I do like that you added docs, but I feel we should let #477 go in first (unless you and @framsouza are collaborating on this PR?)

@justinsb justinsb self-assigned this Apr 3, 2026
@justinsb
Copy link
Copy Markdown
Contributor

justinsb commented Apr 3, 2026

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Apr 3, 2026
@justinsb
Copy link
Copy Markdown
Contributor

justinsb commented Apr 3, 2026

/hold for figuring out overlap with #477

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 3, 2026
@kincoy
Copy link
Copy Markdown
Author

kincoy commented Apr 3, 2026

@justinsb I wasn't aware of #477! Happy to wait for it to merge and rebase this PR to only include the docs/configuration.md update. Thanks!

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

PR needs rebase.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants