Skip to content

WIP: Change codes.ResourceExhausted from non-final to final error #1334

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
+11 −4
Open

WIP: Change codes.ResourceExhausted from non-final to final error #1334

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 11 additions & 4 deletions pkg/sidecar-controller/snapshot_controller.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -744,12 +744,19 @@ func isCSIFinalError(err error) bool {
}
switch st.Code() {
case codes.Canceled, // gRPC: Client Application cancelled the request
codes.DeadlineExceeded, // gRPC: Timeout
codes.Unavailable, // gRPC: Server shutting down, TCP connection broken - previous CreateSnapshot() may be still in progress.
codes.ResourceExhausted, // gRPC: Server temporarily out of resources - previous CreateSnapshot() may be still in progress.
codes.Aborted: // CSI: Operation pending for Snapshot
codes.DeadlineExceeded, // gRPC: Timeout
codes.Unavailable, // gRPC: Server shutting down, TCP connection broken - previous CreateSnapshot() may be still in progress.
codes.Aborted: // CSI: Operation pending for Snapshot
return false
}
// Note: codes.ResourceExhausted is treated as a final error.
// gRPC: Server out of resources.
// However, it also could be from the transport layer for "message size exceeded".
// Cannot be decided properly here and needs to be resolved in the spec
// https://github.com/container-storage-interface/spec/issues/419.
// What we assume here for now is that message size limits are large enough that
// the error really comes from the CSI driver.

// All other errors mean that creating snapshot either did not
// even start or failed. It is for sure not in progress.
return true
Expand Down
Loading