Skip to content

Conversation

xing-yang
Copy link
Collaborator

@xing-yang xing-yang commented Sep 23, 2025

What type of PR is this?
/kind cleanup

What this PR does / why we need it:
This PR changes codes.ResourceExhausted from non-final to final error.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:
Resource_exhausted was initially treated as a non-final error in external-provisioner as well: https://github.com/kubernetes-csi/external-provisioner/pull/312/files.
Later on, it got changed to be a final error: https://github.com/kubernetes-csi/external-provisioner/pull/405/files#diff-243ebed2765f75e6a54f57167212fefb08c3b2a85967ad2acbc0eb78919019c1.
I think we can make a similar change in external-snapshotter. Resource_exhausted due to out of capacity is not a problem that can be fixed quickly. It usually results in infinitely retries if it is treated as a non-final error.

There's a slack thread about this issue: https://kubernetes.slack.com/archives/C09QZFCE5/p1688119656274719

Does this PR introduce a user-facing change?:

Change codes.ResourceExhausted from non-final to final error

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Sep 23, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: xing-yang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Sep 23, 2025
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Sep 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants