WIP: Change codes.ResourceExhausted from non-final to final error #1334
+11
−4
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
This PR changes codes.ResourceExhausted from non-final to final error.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Resource_exhausted was initially treated as a non-final error in external-provisioner as well: https://github.com/kubernetes-csi/external-provisioner/pull/312/files.
Later on, it got changed to be a final error: https://github.com/kubernetes-csi/external-provisioner/pull/405/files#diff-243ebed2765f75e6a54f57167212fefb08c3b2a85967ad2acbc0eb78919019c1.
I think we can make a similar change in external-snapshotter. Resource_exhausted due to out of capacity is not a problem that can be fixed quickly. It usually results in infinitely retries if it is treated as a non-final error.
There's a slack thread about this issue: https://kubernetes.slack.com/archives/C09QZFCE5/p1688119656274719
Does this PR introduce a user-facing change?: