Skip to content

fix: set restricted PSS sample context #1229

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
danish9039 wants to merge 1 commit into
base: notebooks-v2
Choose a base branch
from
+5 −0
Draft

fix: set restricted PSS sample context #1229

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions workspaces/controller/manifests/kustomize/samples/jupyterlab_v1beta1_workspacekind.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -212,6 +212,8 @@ spec:
##
securityContext:
fsGroup: 100
seccompProfile:
type: RuntimeDefault
Comment on lines +215 to +216

@thesuperzapper thesuperzapper Jul 7, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should sanity check that this does not break accelerator intergration for NVIDIA or AMD GPUs.

cc @christian-heusel


## container SecurityContext for Workspace Pods (MUTABLE)
## - spec for SecurityContext:
Expand All @@ -223,6 +225,9 @@ spec:
drop:
- ALL
runAsNonRoot: true
runAsUser: 1000

@thesuperzapper thesuperzapper Jul 7, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have no such requirement to run as 1000, and this has no relation to PSS.

Please remove.

seccompProfile:
type: RuntimeDefault

## ==============================================================
## WORKSPACE OPTIONS
Expand Down
Loading