Skip to content

fix: set restricted PSS sample context#1229

Draft
danish9039 wants to merge 1 commit into
kubeflow:notebooks-v2from
danish9039:pr3487/workspacekind-restricted-pss
Draft

fix: set restricted PSS sample context#1229
danish9039 wants to merge 1 commit into
kubeflow:notebooks-v2from
danish9039:pr3487/workspacekind-restricted-pss

Conversation

@danish9039

Copy link
Copy Markdown
Member

Summary

This PR updates the JupyterLab WorkspaceKind sample so generated workspace pods are compatible with Kubernetes restricted Pod Security Standards.

The change is limited to workspaces/controller/manifests/kustomize/samples/jupyterlab_v1beta1_workspacekind.yaml and adds:

  • pod seccompProfile.type: RuntimeDefault
  • container runAsUser: 1000
  • container seccompProfile.type: RuntimeDefault

Existing fsGroup: 100, allowPrivilegeEscalation: false, capabilities.drop: [ALL], and runAsNonRoot: true are preserved.

No CRD defaults, controller reconciliation logic, codeserver, or rstudio samples are changed.

Validation

  • branch based on kubeflow/notebooks:notebooks-v2
  • kustomize build workspaces/controller/manifests/kustomize/samples
  • source and rendered YAML assertions for the JupyterLab WorkspaceKind
  • git diff --check

Related

Related to kubeflow/community-distribution#3487.

Signed-off-by: danish9039 <danishsiddiqui040@gmail.com>
@google-oss-prow

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign andyatmiami for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow Bot requested a review from andyatmiami July 4, 2026 20:13
@google-oss-prow google-oss-prow Bot added the area/v2 area - version - kubeflow notebooks v2 label Jul 4, 2026
@google-oss-prow google-oss-prow Bot requested a review from thesuperzapper July 4, 2026 20:13
@danish9039 danish9039 changed the title workspaces: set restricted PSS sample context fix: set restricted PSS sample context Jul 4, 2026

@thesuperzapper thesuperzapper left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As long as we resolve the comments, I am ok with this change.

But we should also make the change to the other WorkspaceKind samples.

drop:
- ALL
runAsNonRoot: true
runAsUser: 1000

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have no such requirement to run as 1000, and this has no relation to PSS.

Please remove.

Comment on lines +215 to +216
seccompProfile:
type: RuntimeDefault

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should sanity check that this does not break accelerator intergration for NVIDIA or AMD GPUs.

cc @christian-heusel

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/controller area - related to controller components area/v2 area - version - kubeflow notebooks v2 do-not-merge/work-in-progress size/XS

Projects

Status: Needs Triage

Development

Successfully merging this pull request may close these issues.

2 participants