Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix gateway yaml format and missing label #455

Merged
merged 2 commits into from
Mar 18, 2025
+7 −7
Merged

fix gateway yaml format and missing label #455

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c3d184d
fix gateway api label
Jooho Mar 17, 2025
104096d
fix format of yaml
Jooho Mar 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion docs/admin/gatewayapi_migration.md
View file
Original file line number Diff line number Diff line change
@@ -129,7 +129,7 @@ kubectl rollout restart deployment kserve-controller-manager -n kserve
If you are using a cloud provider, you may need to configure the external traffic to the LoadBalancer service created in [step 4](#4-create-gateway-resource).

```shell
kubectl get svc kserve-ingress-gateway -l -A
kubectl get svc -l serving.kserve.io/gateway=kserve-ingress-gateway -A
```

## 8. Verify the Gateway API configuration
12 changes: 6 additions & 6 deletions docs/admin/kubernetes_deployment.md
View file
Original file line number Diff line number Diff line change
@@ -55,9 +55,9 @@ The minimally required Cert Manager version is 1.15.0 and you can refer to [Cert
- name: http
protocol: HTTP
port: 80
allowedRoutes:
namespaces:
from: All
allowedRoutes:
namespaces:
from: All
- name: https
protocol: HTTPS
port: 443
@@ -70,9 +70,9 @@ The minimally required Cert Manager version is 1.15.0 and you can refer to [Cert
allowedRoutes:
namespaces:
from: All
infrastructure:
labels:
serving.kserve.io/gateway: kserve-ingress-gateway
infrastructure:
labels:
serving.kserve.io/gateway: kserve-ingress-gateway
```
!!! note
KServe comes with a default `Gateway` named kserve-ingress-gateway. You can enable the default gateway by setting Helm value `kserve.controller.gateway.ingressGateway.createGateway` to `true`.