Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix gateway yaml format and missing label #455

Merged
merged 2 commits into from
Mar 18, 2025

Conversation

Jooho
Copy link
Contributor

@Jooho Jooho commented Mar 17, 2025

"Fixes #issue-number" or "Add description of the problem this PR solves"
File (gatewayapi_migration) missed a label name to get gate

Proposed Changes

kubectl get svc kserve-ingress-gateway -l  -A

to

kubectl get svc -l serving.kserve.io/gateway=kserve-ingress-gateway -A

Signed-off-by: Jooho Lee <[email protected]>
Copy link

netlify bot commented Mar 17, 2025

Deploy Preview for elastic-nobel-0aef7a ready!

Name Link
🔨 Latest commit 104096d
🔍 Latest deploy log https://app.netlify.com/sites/elastic-nobel-0aef7a/deploys/67d8865fbd71120008b1f89b
😎 Deploy Preview https://deploy-preview-455--elastic-nobel-0aef7a.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@Jooho Jooho changed the title fix gateway api label fix gateway yaml format and missing label Mar 17, 2025
@Jooho
Copy link
Contributor Author

Jooho commented Mar 17, 2025

/assign @sivanantha321

Signed-off-by: Jooho Lee <[email protected]>
@Jooho Jooho force-pushed the fix_missing_label branch from f9d91c8 to 104096d Compare March 17, 2025 20:30
@sivanantha321
Copy link
Member

/lgtm
/approve

@sivanantha321 sivanantha321 merged commit afb6b16 into kserve:main Mar 18, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants