Skip to content

Fix drawdown label checks in PerformanceMetrics class #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Yosri-Ben-Halima wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Fix drawdown label checks in PerformanceMetrics class #7

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0b99f35
Fix drawdown label checks in PerformanceMetrics class
Nov 14, 2025
ea52896
Merge branch 'main' of https://github.com/konradbachusz/algorithmic-t…
Nov 17, 2025
accd2a0
Fix package version specifications in requirements.txt from ~= to == …
Nov 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion algorithmic_trading_utilities/common/portfolio_ops.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -364,7 +364,8 @@ def report(self):

if (
"Return" in label
or "Drawdown" in label
or "Max Drawdown" in label
or "Average Drawdown" in label
or "VaR" in label
or "CVaR" in label
or "Alpha" in label
Expand Down
14 changes: 7 additions & 7 deletions requirements.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,16 +1,16 @@
alpaca-py>=0.42.1
alpaca-trade-api>=3.2.0
beautifulsoup4~=4.14.2
matplotlib~=3.8.2
numpy~=1.24.4
pandas~=2.0.3
python-dotenv>=1.1.1
matplotlib==3.10.7
numpy==2.2.6
pandas==2.3.3
python-dotenv==1.2.1
pytest~=7.4.4
pytest-mock~=3.3.1
requests>=2.32.5
scikit-learn~=1.3.2
scipy~=1.11.4
seaborn~=0.13.2
scikit-learn==1.7.2
scipy==1.15.3
seaborn==0.13.2
tokenizers==0.13.3
torch==2.8.0
transformers==4.30.0
Expand Down